polyfills:Implement streamable fetch in request/response, Make event.target refer to event.currentTarget. #706
Conversation
|
Seemed CI failed, I'll try to find out the cause later. |
partic2
changed the title
|
Can you please split the changes into 2 PRs, or at least 2 commits? |
Done. |
|
|
||
| function consumed(body) { | ||
| if (body._noBody) { | ||
| if (body._bodySize===0) { |
There was a problem hiding this comment.
Can you please run the linter? There are a number of style errors in the JS code.
src/js/polyfills/fetch/body.js
Outdated
| this._bodyReadable = ReadableStream.from([bodyBuffer]); | ||
| } else if (isPrototypeOf(URLSearchParams.prototype, body)) { | ||
| this._bodyText = body.toString(); | ||
| const bodyBuffer=new TextEncoder().encode(body); |
There was a problem hiding this comment.
Create a TextEncoder instance and use it for both.
| return new Blob(parts); | ||
| } else { | ||
| return this.blob().then(readBlobAsArrayBuffer); | ||
| throw new Error('Unknown body type'); |
src/js/polyfills/fetch/fetch.js
Outdated
|
|
||
| xhr.onprogress=function(){ | ||
| if(controller!=null){ | ||
| controller.enqueue(new Uint8Array(xhr.__tjsGetAndClearResponseBuffer())); |
There was a problem hiding this comment.
Let's make this function hidden under some symbol rather than a __ name. Something like xhr[kXhrGetAndClearResponseBuffer]()
src/js/polyfills/fetch/fetch.js
Outdated
| }) | ||
| }else if(request._bodySize===-1){ | ||
| const reader=request.body.getReader(); | ||
| xhr.__ontjsstreamsenddata=function(){ |
src/js/polyfills/fetch/fetch.js
Outdated
| xhr.__ontjsstreamsenddata=function(){ | ||
| reader.read().then((next)=>{ | ||
| if(next.done){ | ||
| xhr.__tjsStreamSend(null); |
src/xhr.c
Outdated
| */ | ||
|
|
||
| #include "curl-utils.h" | ||
| #include "curl/curl.h" |
There was a problem hiding this comment.
All of these includes should be covered by the existing ones, no need to add them explicitly.
| JS_FreeValue(ctx, arg); | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
Use make format so clang-format takes care of the styling.
|
Please don't mix more commits on this PR. |
Ok, I'll learning how to split commit into individual PR later. |
2 participants
#703 Fix event.target always null issue