Skip to content

fix: prevent server error on invalid /auth/failure requests #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YasharF merged 3 commits into from
Feb 17, 2026
+17 −7
Merged

fix: prevent server error on invalid /auth/failure requests #1552

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b04533
fix: prevent server error on invalid /auth/failure requests
YasharF Feb 17, 2026
7b3eb23
test: remove redundant app.test.js tests
YasharF Feb 17, 2026
67e5800
test: explicit assertion on core route failures
YasharF Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ app.get('/auth/failure', (req, res) => {
const redirectTarget = baseReturnTo || returnTo;

if (!redirectTarget || !isSafeRedirect(redirectTarget) || redirectTarget === req.originalUrl || redirectTarget.startsWith('/auth/')) {
res.redirect('/');
return res.redirect('/');
}
res.redirect(redirectTarget);
});
Expand Down
16 changes: 10 additions & 6 deletions test/app.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,6 @@ describe('GET /forgot', () => {
});
});

describe('GET /api', () => {
it('should return 200 OK', (done) => {
request(app).get('/api').expect(200, done);
});
});

describe('GET /contact', () => {
it('should return 200 OK', (done) => {
request(app).get('/contact').expect(200, done);
Expand All @@ -63,3 +57,13 @@ describe('GET /random-url', () => {
request(app).get('/reset').expect(404, done);
});
});

describe('Other core GET routes do not cause errors', () => {
const routes = ['/logout', '/login/2fa', '/login/2fa/totp', '/login/webauthn-start', '/login/verify/testtoken', '/reset/testtoken', '/account', '/account/verify', '/account/verify/testtoken', '/account/2fa/totp/setup', '/account/webauthn/register', '/auth/failure'];

routes.forEach((route) => {
it(`GET ${route}`, async () => {
await request(app).get(route);
});
});
});