Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes an ignored Mongoose assignment in the OAuth account-linking flow to avoid writing to an undefined User.profile.email field (which is discarded under strict schemas).
Changes:
- Remove
user.profile.emailassignment when linking an OAuth provider to an already-logged-in user.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The User schema doesn't define profile.email, so Mongoose ignores it in strict mode. The email field is populated at account creation (it is required), so this line is unnecessary.
b091d65 to
747b957
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The User schema doesn't define profile.email, so Mongoose ignores it in strict mode. The email field is populated at account creation (it is required), so this line is unnecessary.
Checklist
--no-verifywas not used for the commit(s)npm run lintpassed locally without any errorsnpm testpassed locally without any errorsnpm run test:e2e:replaypassed locally without any errorsnpm run test:e2e:custom -- --project=chromium-nokey-livepassed locally without any errorsDescription
Screenshots of UI changes (browser) and logs/test results (console, terminal, shell, cmd)