bootstrap: don't strip \n for last item on listing (open-telemetry#2820)

xrmx · web-flow · commit 476f6e245a68 · 2024-08-26T12:46:08.000-07:00
diff --git a/opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap.py b/opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap.py
@@ -119,7 +119,7 @@ def _find_installed_libraries():
 
 def _run_requirements():
     logger.setLevel(logging.ERROR)
-    print("\n".join(_find_installed_libraries()), end="")
+    print("\n".join(_find_installed_libraries()))
 
 
 def _run_install():
diff --git a/opentelemetry-instrumentation/tests/test_bootstrap.py b/opentelemetry-instrumentation/tests/test_bootstrap.py
@@ -77,7 +77,7 @@ def test_run_cmd_print(self):
             bootstrap.run()
             self.assertEqual(
                 fake_out.getvalue(),
-                "\n".join(self.installed_libraries),
+                "\n".join(self.installed_libraries) + "\n",
             )
 
     @patch("sys.argv", ["bootstrap", "-a", "install"])

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ def test_run_cmd_print(self):`
`77`	`77`	`bootstrap.run()`
`78`	`78`	`self.assertEqual(`
`79`	`79`	`fake_out.getvalue(),`
`80`		`- "\n".join(self.installed_libraries),`
	`80`	`+ "\n".join(self.installed_libraries) + "\n",`
`81`	`81`	`)`
`82`	`82`
`83`	`83`	`@patch("sys.argv", ["bootstrap", "-a", "install"])`