chore(pr/branch): update branch variable references to branch_slug#258
Merged
chore(pr/branch): update branch variable references to branch_slug#258
Conversation
… templates and values
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the chart to use the new
branch_slugvariable for preview environments and image tags, replacing the previousbranchvariable. It also addsbranch_slugto the GitHub and GitLab PR/MR templates and updates the chart version. The changes ensure consistency and clarity when referencing branch names in preview deployments.Branch slug variable improvements:
charts/applicationset/values.yamlto use{{branch_slug}}instead of{{branch}}for image tags and preview environment values in both GitHub and GitLab repositories. [1] [2] [3]charts/applicationset/values.yamlto reference{{branch_slug}}for dynamically passing the branch of the pull request head.Template enhancements:
branch_slugas an environment variable in both GitHub PR (charts/applicationset/templates/github-pr.yml) and GitLab MR (charts/applicationset/templates/gitlab-mr.yml) templates. [1] [2]Chart metadata updates:
0.17.2incharts/applicationset/Chart.yaml.branch_slugto info sections in GitHub and GitLab PR templates.