This repository was archived by the owner on Jun 24, 2023. It is now read-only.
Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-28
to
+67
| if str(getenv("SUPPORT_CHANNEL")).strip() == "": | ||
| SUPPORT_CHANNEL = None | ||
| else: | ||
| SUPPORT_CHANNEL = str(getenv("SUPPORT_CHANNEL")) | ||
| if str(getenv("SUPPORT_GROUP")).strip() == "": | ||
| SUPPORT_GROUP = None | ||
| else: | ||
| SUPPORT_GROUP = str(getenv("SUPPORT_GROUP")) | ||
|
|
||
|
|
||
| if str(getenv("STRING_SESSION1")).strip() == "": | ||
| STRING1 = str(None) | ||
| else: | ||
| STRING1 = str(getenv("STRING_SESSION1")) | ||
|
|
||
| if str(getenv("STRING_SESSION2")).strip() == "": | ||
| STRING2 = str(None) | ||
| else: | ||
| STRING2 = str(getenv("STRING_SESSION2")) | ||
|
|
||
| if str(getenv("STRING_SESSION3")).strip() == "": | ||
| STRING3 = str(None) | ||
| else: | ||
| STRING3 = str(getenv("STRING_SESSION3")) | ||
|
|
||
| if str(getenv("STRING_SESSION4")).strip() == "": | ||
| STRING4 = str(None) | ||
| else: | ||
| STRING4 = str(getenv("STRING_SESSION4")) | ||
|
|
||
| if str(getenv("STRING_SESSION5")).strip() == "": | ||
| STRING5 = str(None) | ||
| else: | ||
| STRING5 = str(getenv("STRING_SESSION5")) | ||
|
|
||
| if str(getenv("LOG_SESSION")).strip() == "": | ||
| LOG_SESSION = str(None) | ||
| else: | ||
| LOG_SESSION = str(getenv("LOG_SESSION")) | ||
| SUPPORT_CHANNEL = ( | ||
| str(getenv("SUPPORT_CHANNEL")) | ||
| if str(getenv("SUPPORT_CHANNEL")).strip() | ||
| else None | ||
| ) | ||
| SUPPORT_GROUP = ( | ||
| str(getenv("SUPPORT_GROUP")) | ||
| if str(getenv("SUPPORT_GROUP")).strip() | ||
| else None | ||
| ) | ||
| STRING1 = ( | ||
| str(getenv("STRING_SESSION1")) | ||
| if str(getenv("STRING_SESSION1")).strip() | ||
| else str(None) | ||
| ) | ||
| STRING2 = ( | ||
| str(getenv("STRING_SESSION2")) | ||
| if str(getenv("STRING_SESSION2")).strip() | ||
| else str(None) | ||
| ) | ||
| STRING3 = ( | ||
| str(getenv("STRING_SESSION3")) | ||
| if str(getenv("STRING_SESSION3")).strip() | ||
| else str(None) | ||
| ) | ||
| STRING4 = ( | ||
| str(getenv("STRING_SESSION4")) | ||
| if str(getenv("STRING_SESSION4")).strip() | ||
| else str(None) | ||
| ) | ||
| STRING5 = ( | ||
| str(getenv("STRING_SESSION5")) | ||
| if str(getenv("STRING_SESSION5")).strip() | ||
| else str(None) | ||
| ) | ||
| LOG_SESSION = ( | ||
| str(getenv("LOG_SESSION")) | ||
| if str(getenv("LOG_SESSION")).strip() | ||
| else str(None) | ||
| ) |
Author
There was a problem hiding this comment.
Lines 28-66 refactored with the following changes:
- Replaces an empty collection equality with a boolean operation [×8] (
simplify-empty-collection-comparison) - Replace if statement with if expression [×8] (
assign-if-exp) - Swap if/else branches of if expression to remove negation [×8] (
swap-if-expression)
Comment on lines
-108
to
+109
| "[magenta] MissCutie Music Bot Booting...", | ||
| ) as status: | ||
| "[magenta] MissCutie Music Bot Booting...", | ||
| ) as status: |
Author
There was a problem hiding this comment.
Function initiate_bot refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation) - Swap if/else branches of if expression to remove negation (
swap-if-expression)
Comment on lines
-36
to
+37
| "[magenta] Finalizing Booting...", | ||
| ) as status: | ||
| "[magenta] Finalizing Booting...", | ||
| ) as status: |
Author
There was a problem hiding this comment.
Function initiate_bot refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting) - Use f-string instead of string concatenation (
use-fstring-for-concatenation) - Replace f-string with no interpolated values with string (
remove-redundant-fstring)
Comment on lines
-256
to
+254
| user = ( | ||
| user.first_name if not user.mention else user.mention | ||
| ) | ||
| user = user.mention or user.first_name |
Author
There was a problem hiding this comment.
Function start_command refactored with the following changes:
- Swap if/else branches of if expression to remove negation [×2] (
swap-if-expression) - Simplify if expression by using or [×2] (
or-if-exp-identity)
Comment on lines
-409
to
+402
| module = mod_match.group(1) | ||
| text = ( | ||
| "{} **{}**:\n".format( | ||
| "Here is the help for", HELPABLE[module].__MODULE__ | ||
| ) | ||
| + HELPABLE[module].__HELP__ | ||
| ) | ||
| module = mod_match[1] | ||
| text = f"Here is the help for **{HELPABLE[module].__MODULE__}**:\n{HELPABLE[module].__HELP__}" |
Author
There was a problem hiding this comment.
Function help_button refactored with the following changes:
- Replace m.group(x) with m[x] for re.Match objects [×3] (
use-getitem-for-re-match-groups) - Replace call to format with f-string (
use-fstring-for-formatting) - Use f-string instead of string concatenation (
use-fstring-for-concatenation) - Simplify unnecessary nesting, casting and constant values in f-strings (
simplify-fstring-formatting)
Comment on lines
-17
to
+14
| if not _notes: | ||
| return {} | ||
| return _notes["notes"] | ||
| return _notes["notes"] if _notes else {} |
Author
There was a problem hiding this comment.
Function _get_assistant refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp) - Swap if/else branches of if expression to remove negation (
swap-if-expression)
Comment on lines
-25
to
+20
| if name in _notes: | ||
| return _notes[name] | ||
| else: | ||
| return False | ||
| return _notes[name] if name in _notes else False |
Author
There was a problem hiding this comment.
Function get_assistant refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
| if not user: | ||
| return False | ||
| return True | ||
| return bool(user) |
Author
There was a problem hiding this comment.
Function is_nonadmin_chat refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp) - Simplify boolean if expression (
boolean-if-exp-identity)
Comment on lines
-49
to
+47
| if not _notes: | ||
| return {} | ||
| return _notes["notes"] | ||
| return _notes["notes"] if _notes else {} |
Author
There was a problem hiding this comment.
Function _get_authusers refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp) - Swap if/else branches of if expression to remove negation (
swap-if-expression)
Comment on lines
-55
to
+51
| _notes = [] | ||
| for note in await _get_authusers(chat_id): | ||
| _notes.append(note) | ||
| return _notes | ||
| return list(await _get_authusers(chat_id)) |
Author
There was a problem hiding this comment.
Function get_authuser_names refactored with the following changes:
- Convert for loop into list comprehension (
list-comprehension) - Replace identity comprehension with call to collection constructor (
identity-comprehension) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-64
to
+57
| if name in _notes: | ||
| return _notes[name] | ||
| else: | ||
| return False | ||
| return _notes[name] if name in _notes else False |
Author
There was a problem hiding this comment.
Function get_authuser refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
| for chat in await chats.to_list(length=1000000000): | ||
| chats_list.append(chat) | ||
| return chats_list | ||
| return list(await chats.to_list(length=1000000000)) if chats else [] |
Author
There was a problem hiding this comment.
Function get_served_chats refactored with the following changes:
- Convert for loop into list comprehension (
list-comprehension) - Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp) - Swap if/else branches of if expression to remove negation (
swap-if-expression) - Replace identity comprehension with call to collection constructor (
identity-comprehension) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-20
to
+15
| if not chat: | ||
| return False | ||
| return True | ||
| return bool(chat) |
Author
There was a problem hiding this comment.
Function is_served_chat refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp) - Simplify boolean if expression (
boolean-if-exp-identity)
| if not user: | ||
| return False | ||
| return True | ||
| return bool(user) |
Author
There was a problem hiding this comment.
Function is_gbanned_user refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp) - Simplify boolean if expression (
boolean-if-exp-identity)
| if not onoff: | ||
| return False | ||
| return True | ||
| return bool(onoff) |
Author
There was a problem hiding this comment.
Function is_on_off refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp) - Simplify boolean if expression (
boolean-if-exp-identity)
| if not sudoers: | ||
| return [] | ||
| return sudoers["sudoers"] | ||
| return sudoers["sudoers"] if sudoers else [] |
Author
There was a problem hiding this comment.
Function get_sudoers refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp) - Swap if/else branches of if expression to remove negation (
swap-if-expression)
| if not _notes: | ||
| return {} | ||
| return _notes["notes"] | ||
| return _notes["notes"] if _notes else {} |
Author
There was a problem hiding this comment.
Function _get_theme refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp) - Swap if/else branches of if expression to remove negation (
swap-if-expression)
Comment on lines
-18
to
+16
| if name in _notes: | ||
| return _notes[name] | ||
| else: | ||
| return False | ||
| return _notes[name] if name in _notes else False |
Author
There was a problem hiding this comment.
Function get_theme refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
| if not limit: | ||
| return "" | ||
| return limit["limit"] | ||
| return limit["limit"] if limit else "" |
Author
There was a problem hiding this comment.
Function get_video_limit refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp) - Swap if/else branches of if expression to remove negation (
swap-if-expression)
Comment on lines
-29
to
+27
| if not chats: | ||
| return [] | ||
| chats_list = [] | ||
| for chat in await chats.to_list(length=1000000000): | ||
| chats_list.append(chat) | ||
| return chats_list | ||
| return list(await chats.to_list(length=1000000000)) if chats else [] |
Author
There was a problem hiding this comment.
Function get_active_video_chats refactored with the following changes:
- Convert for loop into list comprehension (
list-comprehension) - Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp) - Swap if/else branches of if expression to remove negation (
swap-if-expression) - Replace identity comprehension with call to collection constructor (
identity-comprehension) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-39
to
+32
| if not chat: | ||
| return False | ||
| return True | ||
| return bool(chat) |
Author
There was a problem hiding this comment.
Function is_active_video_chat refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp) - Simplify boolean if expression (
boolean-if-exp-identity)
Comment on lines
-22
to
+31
| if not member.can_manage_voice_chats: | ||
| if message.from_user.id not in SUDOERS: | ||
| token = await int_to_alpha(message.from_user.id) | ||
| _check = await get_authuser_names(message.chat.id) | ||
| if token not in _check: | ||
| return await message.reply( | ||
| "You don't have the required permission to perform this action.\n\n__REQUIRES ADMIN WITH MANAGE VC RIGHTS__" | ||
| ) | ||
| if ( | ||
| not member.can_manage_voice_chats | ||
| and message.from_user.id not in SUDOERS | ||
| ): | ||
| token = await int_to_alpha(message.from_user.id) | ||
| _check = await get_authuser_names(message.chat.id) | ||
| if token not in _check: | ||
| return await message.reply( | ||
| "You don't have the required permission to perform this action.\n\n__REQUIRES ADMIN WITH MANAGE VC RIGHTS__" | ||
| ) |
Author
There was a problem hiding this comment.
Function AdminRightsCheck refactored with the following changes:
- Merge nested if conditions (
merge-nested-ifs)
Comment on lines
-44
to
+52
| if not member.can_manage_voice_chats: | ||
| return await message.reply( | ||
| return ( | ||
| await mystic(_, message) | ||
| if member.can_manage_voice_chats | ||
| else await message.reply( | ||
| "You don't have the required permission to perform this action.\n\n__REQUIRES ADMIN WITH MANAGE VC RIGHTS__" | ||
| ) | ||
| return await mystic(_, message) | ||
| ) |
Author
There was a problem hiding this comment.
Function AdminActual refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp) - Swap if/else branches of if expression to remove negation (
swap-if-expression)
Comment on lines
-60
to
-70
| if not a.can_manage_voice_chats: | ||
| if CallbackQuery.from_user.id not in SUDOERS: | ||
| token = await int_to_alpha(CallbackQuery.from_user.id) | ||
| _check = await get_authuser_names( | ||
| CallbackQuery.from_user.id | ||
| if ( | ||
| not a.can_manage_voice_chats | ||
| and CallbackQuery.from_user.id not in SUDOERS | ||
| ): | ||
| token = await int_to_alpha(CallbackQuery.from_user.id) | ||
| _check = await get_authuser_names( | ||
| CallbackQuery.from_user.id | ||
| ) | ||
| if token not in _check: | ||
| return await CallbackQuery.answer( | ||
| "You don't have the required permission to perform this action.\nPermission: MANAGE VOICE CHATS", | ||
| show_alert=True, | ||
| ) | ||
| if token not in _check: | ||
| return await CallbackQuery.answer( | ||
| "You don't have the required permission to perform this action.\nPermission: MANAGE VOICE CHATS", | ||
| show_alert=True, | ||
| ) |
Author
There was a problem hiding this comment.
Function AdminRightsCheckCB refactored with the following changes:
- Merge nested if conditions (
merge-nested-ifs)
Comment on lines
-81
to
+94
| if not a.can_manage_voice_chats: | ||
| return await CallbackQuery.answer( | ||
| return ( | ||
| await mystic(_, CallbackQuery) | ||
| if a.can_manage_voice_chats | ||
| else await CallbackQuery.answer( | ||
| "You don't have the required permission to perform this action.\nPermission: MANAGE VOICE CHATS", | ||
| show_alert=True, | ||
| ) | ||
| return await mystic(_, CallbackQuery) | ||
| ) |
Author
There was a problem hiding this comment.
Function ActualAdminCB refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp) - Swap if/else branches of if expression to remove negation (
swap-if-expression)
Comment on lines
-167
to
-181
| buttons = [ | ||
| return [ | ||
| [ | ||
| InlineKeyboardButton(text="▶️", callback_data=f"resumecb"), | ||
| InlineKeyboardButton(text="⏸️", callback_data=f"pausecb"), | ||
| InlineKeyboardButton(text="⏭️", callback_data=f"skipcb"), | ||
| InlineKeyboardButton(text="⏹️", callback_data=f"stopcb"), | ||
| InlineKeyboardButton(text="▶️", callback_data="resumecb"), | ||
| InlineKeyboardButton(text="⏸️", callback_data="pausecb"), | ||
| InlineKeyboardButton(text="⏭️", callback_data="skipcb"), | ||
| InlineKeyboardButton(text="⏹️", callback_data="stopcb"), | ||
| ], | ||
| [ | ||
| InlineKeyboardButton( | ||
| text="🔗 More Menu", callback_data=f"other {videoid}|{user_id}" | ||
| ), | ||
| InlineKeyboardButton(text="🗑 Close Menu", callback_data=f"close"), | ||
| InlineKeyboardButton(text="🗑 Close Menu", callback_data="close"), | ||
| ], | ||
| ] | ||
| return buttons |
Author
There was a problem hiding this comment.
Function secondary_markup refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable) - Replace f-string with no interpolated values with string [×5] (
remove-redundant-fstring)
Comment on lines
-185
to
-196
| buttons = [ | ||
| return [ | ||
| [ | ||
| InlineKeyboardButton(text="▶️", callback_data=f"resumecb"), | ||
| InlineKeyboardButton(text="⏸️", callback_data=f"pausecb"), | ||
| InlineKeyboardButton(text="⏭️", callback_data=f"skipcb"), | ||
| InlineKeyboardButton(text="⏹️", callback_data=f"stopcb"), | ||
| ], | ||
| [ | ||
| InlineKeyboardButton(text="🗑 Close Menu", callback_data=f"close"), | ||
| InlineKeyboardButton(text="▶️", callback_data="resumecb"), | ||
| InlineKeyboardButton(text="⏸️", callback_data="pausecb"), | ||
| InlineKeyboardButton(text="⏭️", callback_data="skipcb"), | ||
| InlineKeyboardButton(text="⏹️", callback_data="stopcb"), | ||
| ], | ||
| [InlineKeyboardButton(text="🗑 Close Menu", callback_data="close")], | ||
| ] | ||
| return buttons |
Author
There was a problem hiding this comment.
Function secondary_markup2 refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable) - Replace f-string with no interpolated values with string [×5] (
remove-redundant-fstring)
Comment on lines
-203
to
+200
| buttons = [ | ||
| return [ |
Author
There was a problem hiding this comment.
Function primary_markup refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable) - Replace f-string with no interpolated values with string [×5] (
remove-redundant-fstring)
Comment on lines
-227
to
+223
| buttons = [ | ||
| return [ |
Author
There was a problem hiding this comment.
Function timer_markup refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable) - Replace f-string with no interpolated values with string [×5] (
remove-redundant-fstring)
Comment on lines
-254
to
+249
| buttons = [ | ||
| return [ |
Author
There was a problem hiding this comment.
Function audio_markup refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable) - Replace f-string with no interpolated values with string [×5] (
remove-redundant-fstring)
Author
Sourcery Code Quality ReportMerging this PR leaves code quality unchanged.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!