Feature: Allow add multiple files with /file command #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file inputs and provide detailed processing feedback This change allows users to process multiple files in a single command, improving usability. It also adds error handling and notifications for successful and failed file processing, ensuring users receive clear feedback on the command's execution.
…y and maintainability fix(command_processor.py): ensure consistent handling of file content types and improve variable declarations
…e unused notification code to streamline the file command handling process
…e processing and simplify success notification format
lewistransts
commented
Jul 5, 2025
| combined_parts.append(f"<file path='{file_path}'>\n{content}\n</file>") | ||
| combined_content = "\n\n".join(combined_parts) | ||
|
|
||
| message_content: Dict[str, Any] = {"role": "user", "content": [{"type": "text", "text": combined_content}]} |
Collaborator
Author
There was a problem hiding this comment.
Change message_content to this format to be consistence with other messages.
I got issue that can't receive response from LLM when using previous format {"role": "user", "content": [file_content]}
daltonnyx
reviewed
Jul 5, 2025
| content_text: str | ||
| if isinstance(file_content, dict) and "text" in file_content: | ||
| content_text = file_content["text"] | ||
| elif isinstance(file_content, str): |
Collaborator
There was a problem hiding this comment.
do not process file here, llm already handle the file message in agent.format_message function. only append file content to message as it is
Collaborator
Author
There was a problem hiding this comment.
reverted to the previous logic, just modified
- adding a
forloop for supporting multiple files - adding type hints
- changing the message history format to
{"role": "user", "content": [{"type": "text", "text": "<file file_path=".."> .... </file>"]}
…oving unnecessary checks and consolidating logic for better readability and maintainability
lewistransts
force-pushed
the
feat/add-multiple-files
branch
from
9c0ac5d to
d1a4187
Compare
…s to specify it contains dictionaries and enhance file content formatting feat(command_processor.py): wrap file content with XML tags and structure it as a dictionary for better message handling
daltonnyx
reviewed
Jul 6, 2025
| # Process file with the file handling service | ||
| if self.message_handler.file_handler is None: | ||
| self.message_handler.file_handler = FileHandler() | ||
| file_content: Optional[Any] = self.message_handler.file_handler.process_file(file_path) |
Collaborator
There was a problem hiding this comment.
no need to define type for file_content here
daltonnyx
reviewed
Jul 6, 2025
| if file_content: | ||
| if file_content: | ||
| # Wrap file content with XML tags including file path | ||
| formatted_content: str = f'<file file_path="{file_path}">\n{file_content}\n</file>' |
Collaborator
There was a problem hiding this comment.
append directly the file_content value, agent and file_handler already format file content
…emoving unnecessary variable assignments and XML formatting to enhance code clarity and maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.