Feature: Auto-approval for specific tools #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for session and forever approval feat(tool_manager.py): load persistent auto-approved tools from config to maintain user preferences across sessions feat(config_management.py): add methods to manage auto-approval tools in global config for better user experience
…proved tools to clean up the codebase chore(config_management.py): remove commented-out code for ensuring auto_approval_tools key to enhance code clarity
…ainability chore(tool_manager.py): remove commented-out explanation to streamline code readability
…method to the end of the class for better readability and organization
daltonnyx
reviewed
Jul 8, 2025
AgentCrew/modules/chat/console_ui.py
Outdated
| self.console.print( | ||
| Text( | ||
| "\nAllow this tool to run? [y]es/[n]o/[all] future calls: ", | ||
| "\nAllow this tool to run? [y]es/[n]o/[a]lways in this session/[f]orever (this and future sessions): ", |
Collaborator
There was a problem hiding this comment.
should be [a]ll (in this session) instead of [a]lways in this session
daltonnyx
reviewed
Jul 8, 2025
AgentCrew/modules/chat/console_ui.py
Outdated
| saved_text = Text( | ||
| "✓ Tool '", style=RICH_STYLE_YELLOW | ||
| ) | ||
| saved_text.append(tool_use["name"]) |
…mprove clarity fix(console_ui.py): simplify approved text messages for better readability fix(config_management.py): return a default configuration structure with global settings when config file is missing or invalid
daltonnyx
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Persistent Tool Auto-Approval System
Summary
This PR introduces a persistent tool auto-approval system that allows users to permanently approve tools across sessions, in addition to the existing session-based approval.
Key Changes
🔧 Enhanced Tool Approval Options
[f]oreveroption alongside existing[y]es,[n]o, and[a]lwaysoptions[a]lways) and persistent ([f]orever) approvals🏗️ Core Implementation
ToolManager(tool_manager.py)_load_persistent_auto_approved_tools()method to load saved tools from configreset_approved_tools()to preserve persistent approvals while clearing session-based onesConfigManagement(config_management.py)get_auto_approval_tools()method to retrieve persistent auto-approved toolswrite_auto_approval_tools()method to add/remove tools from persistent listauto_approval_toolsarrayConsoleUI(console_ui.py)[f]oreveroption handler that saves tool to persistent config🔄 Behavioral Changes
Before:
[all]were only remembered for the current sessionAfter:
[a]lways- Session-based approval (existing behavior)[f]orever- Persistent approval across all sessions🛡️ Safety & Reliability
📋 User Experience
Technical Details
Config Structure
{ "api_keys": {}, "auto_approval_tools": ["tool1", "tool2", ...] }Flow changes