-
Notifications
You must be signed in to change notification settings - Fork 0
feat: enhance theming support across components with new theme configurations and integration #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…urations and integration
Test Result
Details
|
|
|
||
| export default { | ||
| Accordion: AccordionTheme, | ||
| Button: ButtonTheme, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have ButtonOutline, ButtonPrimary, ButtonSecondary, ButtonTransparent.
So what does Button mean, and used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's used for standard button.
src/theme/components/Typography.ts
Outdated
| }, | ||
| regular: { | ||
| fontSize: 16, | ||
| fontWeight: '400', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 'regular' for synchronization.
src/theme/components/Typography.ts
Outdated
| }, | ||
| h2: { | ||
| fontSize: 24, | ||
| fontWeight: '700', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 'bold' for synchronization.
src/theme/components/Typography.ts
Outdated
| variantStyles: { | ||
| h1: { | ||
| fontSize: 28, | ||
| fontWeight: '700', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 'bold' for synchronization.
src/components/TextInput/README.md
Outdated
| tiny: 4, // Small spacing | ||
| labelStyle: { | ||
| fontSize: 14, | ||
| fontWeight: '500', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 'medium' for synchronization.
src/theme/components/Slider.ts
Outdated
| labelStyle: { | ||
| color: base.colors.white, | ||
| fontSize: 12, | ||
| fontWeight: '500', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 'medium' for synchronization.
src/theme/components/TextInput.ts
Outdated
| }, | ||
| labelStyle: { | ||
| fontSize: 14, | ||
| fontWeight: '500', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 'medium' for synchronization.
src/components/TextInput/README.md
Outdated
| labelStyle: { | ||
| // Default label style | ||
| fontSize: 14, | ||
| fontWeight: '500', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 'medium' for synchronization.
src/theme/components/CodeInput.ts
Outdated
| }, | ||
| textStyle: { | ||
| fontSize: 18, | ||
| fontWeight: '600', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 'semibold' for synchronization.
2de505f to
437c56a
Compare
437c56a to
f1c1f88
Compare
No description provided.