coderabbitai III

Author: st-manu

lessonbuilder/tool/src/java/org/sakaiproject/lessonbuildertool/service/LessonBuilderEntityProducer.java

@@ -1948,12 +1948,15 @@ public String mergeInternal(String siteId, Element root, String archivePath, Str
 			for (Long pageId : calculatedParentMap.keySet()) {
 				Long currentPageId = pageId;
 				Long topParent = null;
-
+				Set<Long> visited = new HashSet<>();
 				while (calculatedParentMap.containsKey(currentPageId)) {
+					if (!visited.add(currentPageId)) {
+						log.warn("Cycle detected in page hierarchy at page {}", currentPageId);
+						break;
+					}
 					topParent = calculatedParentMap.get(currentPageId);
 					currentPageId = topParent;
 				}
-
 				if (topParent != null) {
 					calculatedTopParentMap.put(pageId, topParent);
 				}