Skip to content

Conversation

@jumarub
Copy link
Contributor

@jumarub jumarub commented Jan 26, 2026

https://sakaiproject.atlassian.net/browse/SAK-52306

Summary by CodeRabbit

  • New Features
    • Assignments now track resubmission limits, including support for unlimited resubmissions.
    • Honor pledge option is now available for assignments.

✏️ Tip: You can customize this high-level summary in your review settings.

Copilot AI review requested due to automatic review settings January 26, 2026 10:28

This comment was marked as resolved.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 26, 2026

Walkthrough

Adds two new fields to the SimpleAssignment inner class: resubmissionNumber (String) and honorPledge (boolean). Constructor logic initializes honorPledge from assignment data and populates resubmissionNumber by parsing the ALLOW_RESUBMIT_NUMBER property, with special handling for unlimited resubmissions using localized strings.

Changes

Cohort / File(s) Summary
SimpleAssignment Field and Constructor Updates
assignment/tool/src/java/org/sakaiproject/assignment/entityproviders/AssignmentEntityProvider.java
Added two new private fields: resubmissionNumber (String) and honorPledge (boolean). Both constructors now initialize honorPledge from assignment data and parse the ALLOW_RESUBMIT_NUMBER property to populate resubmissionNumber, with localized "unlimited" string handling for -1 values and automatic enabling of allowResubmission.

Possibly related PRs

  • PR #14283 — Modifies the same SimpleAssignment constructors in AssignmentEntityProvider, adding logging behavior to the constructor that hydrates assignments.

Suggested labels

I18N

Suggested reviewers

  • ottenhoff
  • st-manu
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding resubmission limits and honor pledge support to the SimpleAssignment class.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ern ern changed the title SAK-52306 New parameters for SimpleAssignment SAK-52306 Assignments add resubmission parameters to SimpleAssignment Jan 28, 2026
@ern ern changed the title SAK-52306 Assignments add resubmission parameters to SimpleAssignment SAK-52306 Assignments add resubmission limits to SimpleAssignment Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants