Skip to content

Forked release fix image registry #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Forked release fix image registry #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62ae09c
print value of MANIFEST_IMG
salasberryfin Nov 13, 2024
00ace20
let environment variables override PROD_REGISTRY
salasberryfin Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ ifndef REGISTRY
REGISTRY ?= localhost:5000
endif
STAGING_REGISTRY := gcr.io/k8s-staging-cluster-api-azure
PROD_REGISTRY := registry.k8s.io/cluster-api-azure
PROD_REGISTRY ?= registry.k8s.io/cluster-api-azure
IMAGE_NAME ?= cluster-api-azure-controller
CONTROLLER_IMG ?= $(REGISTRY)/$(IMAGE_NAME)
TAG ?= dev
Expand Down Expand Up @@ -636,6 +636,9 @@ release: clean-release ## Builds and push container images using the latest git
@if ! [ -z "$$(git status --porcelain)" ]; then echo "Your local git repository contains uncommitted changes, use git clean before proceeding."; exit 1; fi
git checkout "${RELEASE_TAG}"
# Set the manifest image to the production bucket.
echo ""
echo "#### Setting the manigest image to: $(PROD_REGISTRY)/$(IMAGE_NAME) and manifest tag to: $(RELEASE_TAG)"
echo ""
$(MAKE) set-manifest-image MANIFEST_IMG=$(PROD_REGISTRY)/$(IMAGE_NAME) MANIFEST_TAG=$(RELEASE_TAG)
$(MAKE) set-manifest-pull-policy PULL_POLICY=IfNotPresent
$(MAKE) release-manifests
Expand Down
Loading