Refresh E2E test data from new Saleor Cloud snapshot and align Playwright tests#6398
Refresh E2E test data from new Saleor Cloud snapshot and align Playwright tests#6398
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR refreshes Playwright E2E fixtures to match a new Saleor Cloud snapshot, updates tests/page objects to align with the refreshed catalog/entities, and adjusts CI helpers/workflows to support the updated setup.
Changes:
- Updated
playwright/data/e2eTestData.tsfixture IDs/names to match the new snapshot. - Aligned multiple Playwright specs and page objects with updated entities/flows (translations, taxes, shipping, orders, products, etc.).
- Updated GitHub Actions workflow/composite actions to load secrets via 1Password and to adjust snapshot namespace selection.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| playwright/tests/translations.spec.ts | Updates translation tests to use refreshed entities/locale identifiers. |
| playwright/tests/taxes.spec.ts | Updates tax-rate entry values and target country for refreshed dataset. |
| playwright/tests/shippingMethods.spec.ts | Renames fixture references to updated shipping-zone data structure. |
| playwright/tests/product.spec.ts | Updates product fixture IDs and adds attribute selection step. |
| playwright/tests/orders.spec.ts | Updates mark-as-paid reference method and adds warehouse selection during fulfillment. |
| playwright/tests/navigation.spec.ts | Updates navigation item selection to match refreshed catalog labels. |
| playwright/tests/giftCards.spec.ts | Updates gift card dialog locator usage; comments out part of verification flow. |
| playwright/tests/discounts.spec.ts | Updates gift reward selection to match refreshed product naming. |
| playwright/tests/categories.spec.ts | Updates expected product text in category test to match refreshed data. |
| playwright/pages/translationsPage.ts | Updates locale test-id locator naming (PL_PL -> PL). |
| playwright/pages/taxesPage.ts | Reworks tax rate inputs to match new tax-class layout/labels. |
| playwright/pages/productPage.ts | Adds helper to select an attribute value during product creation/editing. |
| playwright/pages/pageElements/rightSideDetailsSection.ts | Fixes missing await calls and updates default customer email. |
| playwright/pages/fulfillmentPage.ts | Adds warehouse selection to fulfillment flow. |
| playwright/pages/forms/addressForm.ts | Adds click before filling phone input to improve stability. |
| playwright/pages/dialogs/promotionRuleDialog.ts | Ensures condition value is filled before selecting an option. |
| playwright/pages/dialogs/productCreateDialog.ts | Updates default product type used in dialog selection. |
| playwright/pages/dialogs/markOrderAsPaidDialog.ts | Renames helper to reflect “transaction reference” semantics. |
| playwright/pages/dialogs/issueGiftCardDialog.ts | Renames dropdown locator to currencyDropdown. |
| playwright/data/e2eTestData.ts | Refreshes IDs/names across fixtures; introduces TAXES constants. |
| .github/workflows/pr-automation.yml | Loads secrets via 1Password for account prep; updates permissions password secret path. |
| .github/actions/prepare-api-variables/action.yml | Adjusts backup namespace selection logic for release branches and main. |
| .github/actions/prepare-accounts/action.yml | Changes masking behavior for generated ACCOUNTS output. |
| run: | | ||
| ACCOUNTS=$(node playwright/auth.js login) | ||
| echo "::add-mask::${ACCOUNTS}" | ||
| # echo "::add-mask::${ACCOUNTS}" |
There was a problem hiding this comment.
Commenting out ::add-mask::${ACCOUNTS} will allow the ACCOUNTS value to appear in logs if echoed by subsequent steps or if GitHub prints step outputs for debugging. Since this output is derived from credentials (even if encrypted), it should remain masked; restore the add-mask call or replace it with masking of the underlying secret inputs.
| # echo "::add-mask::${ACCOUNTS}" | |
| echo "::add-mask::${ACCOUNTS}" |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6398 +/- ##
=======================================
Coverage 43.12% 43.13%
=======================================
Files 2522 2524 +2
Lines 43985 44006 +21
Branches 10009 10011 +2
=======================================
+ Hits 18967 18980 +13
- Misses 24977 24985 +8
Partials 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Scope of the change
e2eTestData.tsI propose to change the name of the new snap to
snapshot-e2e-testsandsnapshot-e2e-tests-3.XXso we won't be confused with the old namesToDo:
snapshot-e2e-tests-3.22snapshot-e2e-tests