Skip to content

Refresh E2E test data from new Saleor Cloud snapshot and align Playwright tests#6398

Draft
szczecha wants to merge 14 commits intomainfrom
update-e2e-test-data-for-refreshed-snapshot
Draft

Refresh E2E test data from new Saleor Cloud snapshot and align Playwright tests#6398
szczecha wants to merge 14 commits intomainfrom
update-e2e-test-data-for-refreshed-snapshot

Conversation

@szczecha
Copy link
Member

@szczecha szczecha commented Mar 6, 2026

Scope of the change

  • Created a new Saleor Cloud snapshot based on the newest sample DB.
  • Recreated the required data set used by E2E flows and updated references in e2eTestData.ts
  • Updated related Playwright tests/pages to match the refreshed data and current entities.
  • Fixed naming inconsistencies for selected values/methods used in tests.
  • Removed unnecessary products and outdated code comments.
  • Updated CI/workflow helpers to support refreshed data/setup paths

I propose to change the name of the new snap to snapshot-e2e-tests and snapshot-e2e-tests-3.XX so we won't be confused with the old names

ToDo:

  • Apps tests
    • Apps smoke tests and (install and delete)
      • Restore apps on v322 and install and configure apps
      • Create snapshot with name snapshot-e2e-tests-3.22
      • Run test to confirm all is good
  • Main tests
    • Restore snapshot on automation - staging
    • Create new snap for main with name: snapshot-e2e-tests
    • Run test to confirm all is good
  • Workflows (pr automation, manual, on core release)
    • Load test data from 1Password
    • Make sure that all 3.22 and main use the new snapshot

@szczecha szczecha added run pw-e2e Run e2e (basic suite from PR automation) skip changeset Use if your changes doesn't need entry in changelog labels Mar 6, 2026
Copilot AI review requested due to automatic review settings March 6, 2026 16:15
@szczecha szczecha added the test deployment Deploy Pull Request to *.saleor.rocks environment label Mar 6, 2026
@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2026

⚠️ No Changeset found

Latest commit: e4a61f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refreshes Playwright E2E fixtures to match a new Saleor Cloud snapshot, updates tests/page objects to align with the refreshed catalog/entities, and adjusts CI helpers/workflows to support the updated setup.

Changes:

  • Updated playwright/data/e2eTestData.ts fixture IDs/names to match the new snapshot.
  • Aligned multiple Playwright specs and page objects with updated entities/flows (translations, taxes, shipping, orders, products, etc.).
  • Updated GitHub Actions workflow/composite actions to load secrets via 1Password and to adjust snapshot namespace selection.

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
playwright/tests/translations.spec.ts Updates translation tests to use refreshed entities/locale identifiers.
playwright/tests/taxes.spec.ts Updates tax-rate entry values and target country for refreshed dataset.
playwright/tests/shippingMethods.spec.ts Renames fixture references to updated shipping-zone data structure.
playwright/tests/product.spec.ts Updates product fixture IDs and adds attribute selection step.
playwright/tests/orders.spec.ts Updates mark-as-paid reference method and adds warehouse selection during fulfillment.
playwright/tests/navigation.spec.ts Updates navigation item selection to match refreshed catalog labels.
playwright/tests/giftCards.spec.ts Updates gift card dialog locator usage; comments out part of verification flow.
playwright/tests/discounts.spec.ts Updates gift reward selection to match refreshed product naming.
playwright/tests/categories.spec.ts Updates expected product text in category test to match refreshed data.
playwright/pages/translationsPage.ts Updates locale test-id locator naming (PL_PL -> PL).
playwright/pages/taxesPage.ts Reworks tax rate inputs to match new tax-class layout/labels.
playwright/pages/productPage.ts Adds helper to select an attribute value during product creation/editing.
playwright/pages/pageElements/rightSideDetailsSection.ts Fixes missing await calls and updates default customer email.
playwright/pages/fulfillmentPage.ts Adds warehouse selection to fulfillment flow.
playwright/pages/forms/addressForm.ts Adds click before filling phone input to improve stability.
playwright/pages/dialogs/promotionRuleDialog.ts Ensures condition value is filled before selecting an option.
playwright/pages/dialogs/productCreateDialog.ts Updates default product type used in dialog selection.
playwright/pages/dialogs/markOrderAsPaidDialog.ts Renames helper to reflect “transaction reference” semantics.
playwright/pages/dialogs/issueGiftCardDialog.ts Renames dropdown locator to currencyDropdown.
playwright/data/e2eTestData.ts Refreshes IDs/names across fixtures; introduces TAXES constants.
.github/workflows/pr-automation.yml Loads secrets via 1Password for account prep; updates permissions password secret path.
.github/actions/prepare-api-variables/action.yml Adjusts backup namespace selection logic for release branches and main.
.github/actions/prepare-accounts/action.yml Changes masking behavior for generated ACCOUNTS output.

run: |
ACCOUNTS=$(node playwright/auth.js login)
echo "::add-mask::${ACCOUNTS}"
# echo "::add-mask::${ACCOUNTS}"
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out ::add-mask::${ACCOUNTS} will allow the ACCOUNTS value to appear in logs if echoed by subsequent steps or if GitHub prints step outputs for debugging. Since this output is derived from credentials (even if encrypted), it should remain masked; restore the add-mask call or replace it with masking of the underlying secret inputs.

Suggested change
# echo "::add-mask::${ACCOUNTS}"
echo "::add-mask::${ACCOUNTS}"

Copilot uses AI. Check for mistakes.
@github-actions github-actions bot temporarily deployed to pr-6398 March 6, 2026 16:23 Destroyed
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.13%. Comparing base (4c95e29) to head (e4a61f1).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6398   +/-   ##
=======================================
  Coverage   43.12%   43.13%           
=======================================
  Files        2522     2524    +2     
  Lines       43985    44006   +21     
  Branches    10009    10011    +2     
=======================================
+ Hits        18967    18980   +13     
- Misses      24977    24985    +8     
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@szczecha szczecha added run pw-e2e Run e2e (basic suite from PR automation) test deployment Deploy Pull Request to *.saleor.rocks environment and removed run pw-e2e Run e2e (basic suite from PR automation) test deployment Deploy Pull Request to *.saleor.rocks environment labels Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run pw-e2e Run e2e (basic suite from PR automation) skip changeset Use if your changes doesn't need entry in changelog test deployment Deploy Pull Request to *.saleor.rocks environment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants