Draft
Conversation
🦋 Changeset detectedLatest commit: a7d892f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
13 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6407 +/- ##
=======================================
Coverage 43.13% 43.13%
=======================================
Files 2524 2526 +2
Lines 44009 44013 +4
Branches 10011 10015 +4
=======================================
+ Hits 18983 18985 +2
- Misses 24985 24987 +2
Partials 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Dashboard support for Saleor’s new passwordLoginMode shop setting, exposing it in Site Settings and using it to control whether the password-based login form is shown on the Sign In page. This also updates the local schema snapshot and generated GraphQL typings to include the new field (and other upstream schema changes).
Changes:
- Extend Site Settings form + mutation payload to edit
shop.passwordLoginModevia a new radio-group card. - Update Sign In flow to fetch
passwordLoginModeand hide email/password inputs unless the mode isENABLED. - Refresh GraphQL schema snapshot, fragments, and generated client types to include
passwordLoginModeand other schema updates.
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/siteSettings/views/index.tsx | Sends passwordLoginMode in shopSettingsInput when saving Site Settings. |
| src/siteSettings/fixtures.ts | Adds passwordLoginMode to Site Settings fixture data. |
| src/siteSettings/components/SiteSettingsPage/messages.ts | Adds i18n strings for the new Password Login section header/description. |
| src/siteSettings/components/SiteSettingsPage/SiteSettingsPage.tsx | Adds passwordLoginMode to form state and renders the new settings section/card. |
| src/siteSettings/components/SitePasswordLoginCard/messages.ts | Introduces i18n strings for the radio options (and currently unused section strings). |
| src/siteSettings/components/SitePasswordLoginCard/SitePasswordLoginCard.tsx | New card component to edit passwordLoginMode via radio choices. |
| src/graphql/typePolicies.generated.ts | Regenerated GraphQL client type policies (includes passwordLoginMode). |
| src/graphql/hooks.generated.ts | Adds passwordLoginMode to Shop fragment and AvailableExternalAuthentications query selection set. |
| src/graphql/fragmentTypes.generated.ts | Updates possible types for unions after schema refresh. |
| src/graphql/fabbricaTypes.generated.ts | Regenerated GraphQL TS types (includes PasswordLoginModeEnum). |
| src/graphql/fabbrica.generated.ts | Regenerated fabbrica factories/types after schema refresh. |
| src/fragments/shop.ts | Adds passwordLoginMode to shopFragment. |
| src/auth/views/Login.tsx | Fetches passwordLoginMode and passes passwordLoginEnabled to LoginPage. |
| src/auth/queries.ts | Extends AvailableExternalAuthentications query to include passwordLoginMode. |
| src/auth/components/LoginPage/LoginPage.tsx | Conditionally hides email/password fields when password login is disabled. |
| src/auth/components/LoginPage/LoginPage.test.tsx | Updates test props to include new required passwordLoginEnabled. |
| schema-main.graphql | Schema snapshot updated with PasswordLoginModeEnum and other upstream schema changes. |
| locale/defaultMessages.json | Adds extracted default messages for new i18n IDs. |
| .changeset/tangy-friends-follow.md | Adds a minor changeset describing the new setting and login behavior. |
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of the change
Add implementation for saleor/saleor#18917
password login modepasswordLoginModeisDISABLEDorCUSTOMERS_ONLY