Fix e2e workflow (sharded) by witoszekdev · Pull Request #6408 · saleor/saleor-dashboard

witoszekdev · 2026-03-10T14:46:01Z

Fixed issue where masking caused sharded test workflow to break

This is not a security issue, it worked previously since it's already encrypted

e2e test now pass fine: https://github.com/saleor/saleor-dashboard/actions/runs/22908573370/job/66475269789?pr=6408

Fixed run pw-e2e failing due to missing deployment (triggered by separate tag previously)

changeset-bot · 2026-03-10T14:46:10Z

🦋 Changeset detected

Latest commit: 2b353fc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot

Pull request overview

Updates the prepare-accounts composite GitHub Action used by the Playwright e2e workflows to avoid a sharded-workflow failure caused by masking the generated accounts payload.

Changes:

Removes ::add-mask::${ACCOUNTS} from the prepare-accounts action step.
Continues to pass the encrypted ACCOUNTS value via $GITHUB_OUTPUT for downstream jobs/steps.

Copilot · 2026-03-10T14:48:21Z

.github/actions/prepare-accounts/action.yml

@@ -46,5 +46,4 @@ runs:
        E2E_PERMISSIONS_USERS_PASSWORD: ${{ inputs.E2E_PERMISSIONS_USERS_PASSWORD }}
      run: |
        ACCOUNTS=$(node playwright/auth.js login)


Consider adding a short comment explaining why ACCOUNTS is intentionally not masked (GitHub Actions may refuse to set step/job outputs that contain masked values and will skip the output). This helps prevent accidental reintroduction of ::add-mask:: which can break sharded workflows again.

Suggested change

ACCOUNTS=$(node playwright/auth.js login)

ACCOUNTS=$(node playwright/auth.js login)

# ACCOUNTS is intentionally not masked here; GitHub Actions may skip step/job outputs

# that contain masked values, which would break consumers (including sharded workflows).

codecov · 2026-03-10T14:49:43Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.13%. Comparing base (e640f8c) to head (2b353fc).

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #6408    +/-   ##
========================================
  Coverage   43.13%   43.13%            
========================================
  Files        2524     2524            
  Lines       44009    44009            
  Branches    10011    10397   +386     
========================================
  Hits        18983    18983            
  Misses      24985    24985            
  Partials       41       41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Copilot · 2026-03-10T15:10:52Z

.changeset/tall-beds-tickle.md

+"saleor-dashboard": patch
+---
+
+`run pw-e2e` label on PRs will now also trigger a deployment. Previously e2e test failed due to a missing deployment without clear error.


Minor grammar: “Previously e2e test failed …” reads like a singular test; consider “Previously, e2e tests failed …” (or “the e2e suite failed …”) to match the meaning and improve clarity in the changelog.

Suggested change

`run pw-e2e` label on PRs will now also trigger a deployment. Previously e2e test failed due to a missing deployment without clear error.

`run pw-e2e` label on PRs will now also trigger a deployment. Previously, e2e tests failed due to a missing deployment without a clear error.

Copilot · 2026-03-10T15:10:53Z

.github/workflows/pr-automation.yml

 jobs:
  initialize-cloud:
-    if: ${{ github.event_name == 'workflow_dispatch' || contains(github.event.pull_request.labels.*.name, 'test deployment') }}
+    if: ${{ github.event_name == 'workflow_dispatch' || contains(github.event.pull_request.labels.*.name, 'test deployment') || contains(github.event.pull_request.labels.*.name, 'run pw-e2e') }}


initialize-cloud now runs when a PR is labeled run pw-e2e, but unlike deploy-dashboard it doesn’t guard against fork PRs. On forks, required secrets (e.g. OP_SERVICE_ACCOUNT_TOKEN) won’t be available, so this job can fail unexpectedly if the label is applied. Consider adding the same github.event.pull_request.head.repo.full_name == 'saleor/saleor-dashboard' check (for pull_request events) to this job’s if: condition, while keeping workflow_dispatch working.

Suggested change

if: ${{ github.event_name == 'workflow_dispatch' || contains(github.event.pull_request.labels.*.name, 'test deployment') || contains(github.event.pull_request.labels.*.name, 'run pw-e2e') }}

if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == 'saleor/saleor-dashboard' && (contains(github.event.pull_request.labels.*.name, 'test deployment') || contains(github.event.pull_request.labels.*.name, 'run pw-e2e'))) }}

Copilot · 2026-03-10T15:10:53Z

.changeset/crisp-crabs-argue.md

+---
+"saleor-dashboard": patch
+---
+
+Fixed main e2e test suite failing due to using masking on shared job output


This PR adds two separate changeset entries for the same underlying CI/workflow fix. That will produce two patch bumps / changelog entries; consider combining into a single changeset to avoid double version increments for one PR.

lkostrowski · 2026-03-11T07:11:48Z

.changeset/crisp-crabs-argue.md

+"saleor-dashboard": patch
+---
+
+Fixed main e2e test suite failing due to using masking on shared job output


I dont this this is actual product changelog. Same way we don't add changelog when we add tests

fix accounts not being passed in full e2e workflow

93bf6f2

witoszekdev requested a review from a team as a code owner March 10, 2026 14:46

witoszekdev requested review from Copilot and lkostrowski March 10, 2026 14:46

Copilot started reviewing on behalf of witoszekdev March 10, 2026 14:46 View session

witoszekdev added the run pw-e2e Run e2e (basic suite from PR automation) label Mar 10, 2026

Copilot AI reviewed Mar 10, 2026

View reviewed changes

witoszekdev added the test deployment Deploy Pull Request to *.saleor.rocks environment label Mar 10, 2026

github-actions bot deployed to pr-6408 March 10, 2026 14:56 View deployment

witoszekdev added 2 commits March 10, 2026 16:05

fix e2e test label not triggering deployment causing it to fail

056ec6a

add changeset

2b353fc

Copilot AI review requested due to automatic review settings March 10, 2026 15:07

Copilot started reviewing on behalf of witoszekdev March 10, 2026 15:07 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

lkostrowski approved these changes Mar 11, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix e2e workflow (sharded)#6408

Fix e2e workflow (sharded)#6408
witoszekdev wants to merge 3 commits intomainfrom
fix-e2e-workflow

witoszekdev commented Mar 10, 2026 •

edited

Loading

Uh oh!

changeset-bot bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 10, 2026

Uh oh!

codecov bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 10, 2026

Uh oh!

Copilot AI Mar 10, 2026

Uh oh!

Copilot AI Mar 10, 2026

Uh oh!

lkostrowski Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	`run pw-e2e` label on PRs will now also trigger a deployment. Previously e2e test failed due to a missing deployment without clear error.
	`run pw-e2e` label on PRs will now also trigger a deployment. Previously, e2e tests failed due to a missing deployment without a clear error.

	if: ${{ github.event_name == 'workflow_dispatch' \|\| contains(github.event.pull_request.labels..name, 'test deployment') \|\| contains(github.event.pull_request.labels..name, 'run pw-e2e') }}
	if: ${{ github.event_name == 'workflow_dispatch' \|\| (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == 'saleor/saleor-dashboard' && (contains(github.event.pull_request.labels..name, 'test deployment') \|\| contains(github.event.pull_request.labels..name, 'run pw-e2e'))) }}

Conversation

witoszekdev commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

lkostrowski Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

witoszekdev commented Mar 10, 2026 •

edited

Loading

changeset-bot bot commented Mar 10, 2026 •

edited

Loading

codecov bot commented Mar 10, 2026 •

edited

Loading