fix(security): harden .gitignore, untrack env files#335
Open
dereyesm wants to merge 2 commits intosaleor:mainfrom
Open
fix(security): harden .gitignore, untrack env files#335dereyesm wants to merge 2 commits intosaleor:mainfrom
dereyesm wants to merge 2 commits intosaleor:mainfrom
Conversation
Saleor 3.22 headless API deploy: api + worker + PostgreSQL 15 + Redis. Country CO, Currency COP. $21/mes estimated. No dashboard (MVP internal). Shared SECRET_KEY via envGroup between api and worker. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Directed-By: Daniel Reyes, CPO Grupo Nymyka
Tracked .env files with potential secrets removed from git tracking. Added .env.example templates for developer setup. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Directed-By: Ares (Arena MULTI-AUDIT-009)
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backend.envandcommon.envfrom git (were committed with defaults).gitignorewith protection for secrets, keys, credentials.env.exampletemplates for developer onboardingContext
Arena MULTI-AUDIT-009: Security audit found these env files tracked in a public repo.
Current values are Saleor defaults but this is an accident waiting to happen.
Test plan
backend.envandcommon.envstill exist locally after merge.examplefiles🤖 Generated with Claude Code