Skip to content

Comments

refactor: refactor login form#1049

Open
grzegorzpokorski wants to merge 6 commits intosaleor:mainfrom
grzegorzpokorski:refactor-login-form
Open

refactor: refactor login form#1049
grzegorzpokorski wants to merge 6 commits intosaleor:mainfrom
grzegorzpokorski:refactor-login-form

Conversation

@grzegorzpokorski
Copy link
Contributor

@grzegorzpokorski grzegorzpokorski commented Nov 27, 2023

Add a few accessibility-related touches to the login form (indicate to the user a loading/pending state)

Before:

before

After:

after

@vercel
Copy link

vercel bot commented Nov 27, 2023

@grzegorzpokorski is attempting to deploy a commit to the Saleor Commerce Team on Vercel.

A member of the Team first needs to authorize it.

@zaiste
Copy link
Contributor

zaiste commented Nov 28, 2023

@grzegorzpokorski let's not nest components in components, our goal is to have a flat file structure with components separated between ui/components and ui/atoms e.g. LoginButton could be in ui/atoms

@grzegorzpokorski
Copy link
Contributor Author

grzegorzpokorski commented Nov 28, 2023

@grzegorzpokorski let's not nest components in components, our goal is to have a flat file structure with components separated between ui/components and ui/atoms e.g. LoginButton could be in ui/atoms

Thank you for the clarification! Initially, this component was located next to the cart page in the src/app/[channel]/(main)/login directory. Perhaps I should move this component back to that directory? What do you think? Should I place components next to the pages files? Answers would make that topic more clear for me 🙂

@grzegorzpokorski
Copy link
Contributor Author

@grzegorzpokorski let's not nest components in components, our goal is to have a flat file structure with components separated between ui/components and ui/atoms e.g. LoginButton could be in ui/atoms

I apologize for any confusion. I will keep that in mind.

@vercel
Copy link

vercel bot commented Jul 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
storefront ✅ Ready (Inspect) Visit Preview Jul 23, 2024 6:37am

@peelar
Copy link
Member

peelar commented May 27, 2025

Hi @grzegorzpokorski, thanks for your contribution. I know it's been quite a long time since you submitted it but could you:

  1. Provide rationale behind these changes and add screenshots
  2. Fix the conflict

I could totally understand if you have no recollection of this PR and don't want to proceed. In that case, I would have to close it 😢.

@grzegorzpokorski
Copy link
Contributor Author

Hi @grzegorzpokorski, thanks for your contribution. I know it's been quite a long time since you submitted it but could you:

  1. Provide rationale behind these changes and add screenshots
  2. Fix the conflict

I could totally understand if you have no recollection of this PR and don't want to proceed. In that case, I would have to close it 😢.

Hi! Thank you for following up on this PR. I'll take a look at this next weekend

@grzegorzpokorski grzegorzpokorski requested a review from a team as a code owner June 1, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants