Skip to content

Comments

Feat/add product breadcrumb#1141

Open
marjan-ahmed wants to merge 8 commits intosaleor:mainfrom
marjan-ahmed:feat/add-product-breadcrumb
Open

Feat/add product breadcrumb#1141
marjan-ahmed wants to merge 8 commits intosaleor:mainfrom
marjan-ahmed:feat/add-product-breadcrumb

Conversation

@marjan-ahmed
Copy link

No description provided.

@marjan-ahmed marjan-ahmed requested a review from a team as a code owner October 13, 2025 11:21
@vercel
Copy link

vercel bot commented Oct 13, 2025

@marjan-ahmed is attempting to deploy a commit to the Saleor Commerce Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Oct 13, 2025

CLA assistant check
All committers have signed the CLA.

@marjan-ahmed
Copy link
Author

Hi team 👋, could someone please authorize the Vercel preview deployment? Thanks!

@vercel
Copy link

vercel bot commented Nov 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
storefront Ready Ready Preview Dec 3, 2025 10:33am

@peelar
Copy link
Member

peelar commented Nov 26, 2025

Hi @marjan-ahmed, there is a bug in your implementation:

  1. Go to preview, click on a product.
  2. In the breadcrumb, click on the "category".

The URL structure is incorrect. It should be:

https://storefront-git-fork-marjan-ahmed-feat-add-0744ae-saleorcommerce.vercel.app/default-channel/categories/gift-cards

instead of:

https://storefront-git-fork-marjan-ahmed-feat-add-0744ae-saleorcommerce.vercel.app/default-channel/category/Gift%20cards

Copy link
Author

@marjan-ahmed marjan-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @peelar, I’ve fixed the breadcrumb URLs:

  • Fetched the category slug from GraphQL.
  • Updated the breadcrumb to use /categories/ instead of /category/.
  • Added a fallback using kebabCase to normalize the category name ("Gift cards" → "gift-cards") if the slug is missing.

Now the URLs are always clean, lowercase, hyphenated, and SEO-friendly, e.g., /default-channel/categories/gift-cards.

Could someone please authorize the Vercel preview deployment for this branch so the latest changes can be verified? Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants