Skip to content

Commit 7b4a5b7

Browse files
authored
fix(dynamic icons): update role for Sa11y tests (#5046)
1 parent b2231ef commit 7b4a5b7

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

RELEASENOTES.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@
44
## Release 2.19.0 - April 12, 2022
55

66
## Components
7+
8+
### [Dynamic Icons](https://www.lightningdesignsystem.com/components/dynamic-icons)
9+
#### Changed
10+
- Updated Global Action Help icon's `role` attribute from `presentation` to `img` for better accessibility compliance
11+
712
### [Global Navigation](https://www.lightningdesignsystem.com/components/global-navigation)
813
#### Added
914
- Added `role="img"` to unread indicator dot to comply with accessibility usage rules for `aria-label`

ui/components/dynamic-icons/RELEASENOTES.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@
66

77
<!-- ## [VERSION] -->
88

9+
## 2.19.0
10+
11+
### Changed
12+
- Updated Global Action Help icon's `role` attribute from `presentation` to `img` for better accessibility compliance
13+
914
## 2.17.0
1015

1116
### Changed

ui/components/dynamic-icons/global-action-help/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ let GlobalActionHelp = () => (
77
xmlns="http://www.w3.org/2000/svg"
88
viewBox="0 -12 78.5 110"
99
aria-labelledby="title"
10-
role="presentation"
10+
role="img"
1111
>
1212
<defs>
1313
<mask id="questionMark" x="0" y="0" width="78.5" height="110">

0 commit comments

Comments
 (0)