Skip to content

Commit c1d8028

Browse files
laurensuhandrewvasilchukLauren SuhDottenpixel
authored
feat(progress-bar): add success color example (#5072)
* feat(progress-bar): add success color example * feat(progress-bar): additional changes to success example * feat(progressbar): typo * feat(progressbar): move ex to states category and update release note * fix location of example in docs * feat(progress-bar): move ex to base Co-authored-by: andrewvasilchuk <[email protected]> Co-authored-by: Lauren Suh <[email protected]> Co-authored-by: DouG Molidor <[email protected]>
1 parent 0282ce9 commit c1d8028

File tree

4 files changed

+21
-6
lines changed

4 files changed

+21
-6
lines changed

RELEASENOTES.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,10 @@
6969
#### Changed
7070
- Added tabindex to Footless example for programmatic focus use case.
7171

72+
### [Progress Bar](https://www.lightningdesignsystem.com/components/progress-bar)
73+
#### Added
74+
- Added example for Success under States
75+
7276
### [Tabs](https://www.lightningdesignsystem.com/components/tabs)
7377
#### Added
7478
- Added `role="img"` to unread indicator dot to comply with accessibility usage rules for `aria-label`

ui/components/progress-bar/RELEASENOTES.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,18 @@
33
# Progress Bar Release Notes
44

55
<!-- ## [Unreleased] -->
6+
## 2.19.0
7+
8+
### Added
9+
10+
- Added example for Success under States
11+
612
## 2.16.0
713

814
### Added
915

1016
- Added `aria-label` attribute to the div with role of `progressbar` to meet accessibility requirements.
1117

12-
1318
## 2.7.0
1419

1520
### Added

ui/components/progress-bar/base/example.jsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,11 @@ export let states = [
6565
id: '100',
6666
label: '100% complete',
6767
element: <ProgressBar value="100" />
68+
},
69+
{
70+
id: 'success',
71+
label: 'Success Color',
72+
element: <ProgressBar isSuccess value="100" />
6873
}
6974
];
7075

@@ -76,11 +81,6 @@ export let examples = [
7681
<ProgressBarDescriptive label="Einstein Setup Assistant" value="25" />
7782
)
7883
},
79-
{
80-
id: 'success',
81-
label: 'Success',
82-
element: <ProgressBar isSuccess value="75" />
83-
},
8484
{
8585
id: 'circular',
8686
label: 'Circular',

ui/components/progress-bar/docs.mdx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,12 @@ import * as Vertical from './vertical/example';
5454
{getDisplayElementById(Base.states, '100')}
5555
</CodeView>
5656

57+
### Success Color
58+
59+
<CodeView>
60+
{getDisplayElementById(Base.states, 'success')}
61+
</CodeView>
62+
5763
## Examples
5864
### Descriptive Progress Bar
5965

0 commit comments

Comments
 (0)