Skip to content

Commit ced8ea1

Browse files
DottenpixelDottenpixel
authored
Revert "Revert "fix(image-paths): Fix hardcoded image paths to prevent build breakage" (#5066)" (#5074)
This reverts commit 74363b1.
1 parent c1d8028 commit ced8ea1

File tree

18 files changed

+66
-30
lines changed

18 files changed

+66
-30
lines changed

‎design-tokens/extensions/ui-force/image-paths.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@ props:
1010
BANNER_GROUP_DEFAULT_IMAGE:
1111
value: ''
1212
USER_DEFAULT_AVATAR:
13-
value: '/assets/images/profile_avatar_200.png'
13+
value: '/profile_avatar_200.png'
1414
USER_DEFAULT_AVATAR_MEDIUM:
15-
value: '/assets/images/profile_avatar_160.png'
15+
value: '/profile_avatar_160.png'
1616
USER_DEFAULT_AVATAR_SMALL:
17-
value: '/assets/images/profile_avatar_96.png'
17+
value: '/profile_avatar_96.png'
1818
GROUP_DEFAULT_AVATAR:
19-
value: '/assets/images/group_avatar_200.png'
19+
value: '/group_avatar_200.png'
2020
GROUP_DEFAULT_AVATAR_MEDIUM:
21-
value: '/assets/images/group_avatar_160.png'
21+
value: '/group_avatar_160.png'
2222
GROUP_DEFAULT_AVATAR_SMALL:
23-
value: '/assets/images/group_avatar_96.png'
23+
value: '/group_avatar_96.png'

‎design-tokens/themes/oneSalesforce/ui-force/background-color.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@ props:
2626
POPOVER_WALKTHROUGH_COLOR_BACKGROUND_ALT:
2727
value: '{!PALETTE_BLUE_50}'
2828
POPOVER_WALKTHROUGH_HEADER_IMAGE:
29-
value: '/assets/images/popovers/popover-header.png'
29+
value: '/popovers/popover-header.png'
3030
type: string
3131
POPOVER_WALKTHROUGH_ALT_IMAGE:
32-
value: '/assets/images/popovers/popover-action.png'
32+
value: '/popovers/popover-action.png'
3333
type: string
3434
POPOVER_WALKTHROUGH_ALT_NUBBIN_COLOR_BACKGROUND:
3535
value: '{!PALETTE_BLUE_50}'

‎design-tokens/themes/oneSalesforce/ui-force/image-paths.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ global:
77
props:
88
## BANNERS
99
BRAND_BAND_DEFAULT_IMAGE:
10-
value: '/assets/images/themes/oneSalesforce/banner-brand-default.png'
10+
value: '/themes/oneSalesforce/banner-brand-default.png'
1111
BANNER_USER_DEFAULT_IMAGE:
12-
value: '/assets/images/themes/oneSalesforce/banner-user-default.png'
12+
value: '/themes/oneSalesforce/banner-user-default.png'
1313
BANNER_GROUP_DEFAULT_IMAGE:
14-
value: '/assets/images/themes/oneSalesforce/banner-group-public-default.png'
14+
value: '/themes/oneSalesforce/banner-group-public-default.png'

‎ui/components/avatar/RELEASENOTES.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22

33
# Avatar Release Notes
44

5+
## 2.19
6+
7+
### Fixed
8+
9+
- Fixed base group image, group image medium and group image small hardcoded image paths
10+
511
## 2.17.0
612

713
### Added

‎ui/components/avatar/base/_index.scss

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
* @restrict .slds-avatar
3434
*/
3535
&.slds-avatar_group-image-small {
36-
background: url($group-default-avatar-small) top left / cover no-repeat;
36+
background: url($static-image-path + $group-default-avatar-small) top left / cover no-repeat;
3737
}
3838

3939
/**
@@ -43,7 +43,7 @@
4343
* @restrict .slds-avatar
4444
*/
4545
&.slds-avatar_group-image-medium {
46-
background: url($group-default-avatar-medium) top left / cover no-repeat;
46+
background: url($static-image-path + $group-default-avatar-medium) top left / cover no-repeat;
4747
}
4848

4949
/**
@@ -53,7 +53,7 @@
5353
* @restrict .slds-avatar
5454
*/
5555
&.slds-avatar_group-image-large {
56-
background: url($group-default-avatar) top left / cover no-repeat;
56+
background: url($static-image-path + $group-default-avatar) top left / cover no-repeat;
5757
}
5858

5959
/**
@@ -63,7 +63,7 @@
6363
* @restrict .slds-avatar
6464
*/
6565
&.slds-avatar_profile-image-small {
66-
background: url($user-default-avatar-small) top left / cover no-repeat;
66+
background: url($static-image-path + $user-default-avatar-small) top left / cover no-repeat;
6767
}
6868

6969
/**
@@ -73,7 +73,7 @@
7373
* @restrict .slds-avatar
7474
*/
7575
&.slds-avatar_profile-image-medium {
76-
background: url($user-default-avatar-medium) top left / cover no-repeat;
76+
background: url($static-image-path + $user-default-avatar-medium) top left / cover no-repeat;
7777
}
7878

7979
/**
@@ -83,7 +83,7 @@
8383
* @restrict .slds-avatar
8484
*/
8585
&.slds-avatar_profile-image-large {
86-
background: url($user-default-avatar) top left / cover no-repeat;
86+
background: url($static-image-path + $user-default-avatar) top left / cover no-repeat;
8787
}
8888
}
8989

‎ui/components/brand-band/RELEASENOTES.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22

33
# Brand Band Release Notes
44

5+
## 2.19
6+
7+
### Fixed
8+
9+
- Fixed base brand band, brand band group and brand band user hardcoded image paths
10+
511
<!-- ## [Unreleased] -->
612

713
<!-- ## [VERSION] -->

‎ui/components/brand-band/base/_index.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
bottom: 0;
2929
left: 0;
3030
background-image:
31-
url($brand-band-default-image),
31+
url($static-image-path + $brand-band-default-image),
3232
linear-gradient(to top, $brand-background-dark-transparent 0, $brand-background-dark);
3333
background-repeat: repeat-x;
3434
background-position: top left;
@@ -154,7 +154,7 @@
154154
* @group image
155155
*/
156156
&.slds-brand-band_group:before {
157-
background-image: url($banner-group-default-image);
157+
background-image: url($static-image-path + $banner-group-default-image);
158158
}
159159

160160
/**
@@ -166,7 +166,7 @@
166166
* @group image
167167
*/
168168
&.slds-brand-band_user:before {
169-
background-image: url($banner-user-default-image);
169+
background-image: url($static-image-path + $banner-user-default-image);
170170
}
171171

172172
// White page for iframes

‎ui/components/einstein-header/RELEASENOTES.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22

33
# Einstein Header Release Notes
44

5+
## 2.19
6+
7+
### Fixed
8+
9+
- Fixed base header and header figure hardcoded image paths
10+
511
<!-- ## [Unreleased] -->
612

713
<!-- ## [VERSION] -->

‎ui/components/einstein-header/base/_index.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
.slds-einstein-header {
66
position: relative;
77
background-color: $einstein-header-background-color;
8-
background-image: url($einstein-header-background);
8+
background-image: url($static-image-path + $einstein-header-background);
99
background-repeat: no-repeat;
1010
background-position: left top;
1111
background-size: cover;
@@ -28,7 +28,7 @@
2828
.slds-einstein-header__figure:last-child {
2929
margin-bottom: calc((#{$spacing-small} + 5px) * -1);
3030
height: rem(76px);
31-
background-image: url($einstein-header-figure);
31+
background-image: url($static-image-path + $einstein-header-figure);
3232
background-position: right bottom;
3333
background-repeat: no-repeat;
3434
}

‎ui/components/einstein-header/tokens/background-color.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ imports:
88
- "../../../../design-tokens/aliases/color-palettes.yml"
99
props:
1010
EINSTEIN_HEADER_BACKGROUND:
11-
value: '/assets/images/einstein-headers/einstein-header-background.svg'
11+
value: '/einstein-headers/einstein-header-background.svg'
1212
type: string
1313
EINSTEIN_HEADER_FIGURE:
14-
value: '/assets/images/einstein-headers/einstein-figure.svg'
14+
value: '/einstein-headers/einstein-figure.svg'
1515
type: string
1616
EINSTEIN_HEADER_BACKGROUND_COLOR:
1717
value: '{!PALETTE_CLOUD_BLUE_80}'

0 commit comments

Comments
 (0)