fix(combobox): associate label with button#725
Open
andrewvasilchuk wants to merge 1 commit intosalesforce-ux:mainfrom
Open
fix(combobox): associate label with button#725andrewvasilchuk wants to merge 1 commit intosalesforce-ux:mainfrom
andrewvasilchuk wants to merge 1 commit intosalesforce-ux:mainfrom
Conversation
Contributor
|
Hello, thanks so much for your contribution. I've created an internal ticket to shepard this through our workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Base Combobox example
<label>is associated with non-existed<input>element. The value offorattribute is theidof the<input>element, which is not rendered in DOM. Instead a<button>element is rendered.The proposed change is to associate label with a button, instead of associating it with a non-existing input element.