This repository was archived by the owner on May 1, 2025. It is now read-only.
fix(akita): restrict usage of sortByOrder to valid usages in type system#667
Open
cgrabmann wants to merge 1 commit intosalesforce:masterfrom
Open
fix(akita): restrict usage of sortByOrder to valid usages in type system#667cgrabmann wants to merge 1 commit intosalesforce:masterfrom
cgrabmann wants to merge 1 commit intosalesforce:masterfrom
Conversation
Collaborator
|
Thanks, we'll merge it in v7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When using
getAllorselectAllfrom aQueryEntityand providing asortByfunction, thesortByOrderis ignored. This is not represented in the type system and therefore lead to some initial confusion in our team.Issue Number: N/A
What is the new behavior?
sortByOrdercan no longer be provided when providing asortByfunction. This is now restricted by the type system.sortByOrdercan can still be provided when providing asortByfield.Does this PR introduce a breaking change?
Projects that provided a
sortByOrderand asortByfunction will have a failing build and need to remove thesortByOrderOther information