Add slackAPI interface and inject dependencies for coverage#94
Merged
justinharringa merged 1 commit intomainfrom Mar 5, 2026
Merged
Add slackAPI interface and inject dependencies for coverage#94justinharringa merged 1 commit intomainfrom
justinharringa merged 1 commit intomainfrom
Conversation
Extract a slackAPI interface from slack-go/slack, inject apiFactory and webhookPoster into productionSlackClientWorker, and add a compile-time guard so breaking changes to PostMessage fail the build immediately. Add tests for productionSlackClientWorker covering success and error paths for both postChannelMessage and postWebhookMessage, plus two error-propagation cases in PostToSlack. Coverage rises from ~78% to 92%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slackAPIinterface mirroringslack.Client.PostMessageand adds a compile-time assertion (var _ slackAPI = (*slack.Client)(nil)) so any future breaking change to theslack-go/slackAPI fails the build immediatelyapiFactoryandwebhookPosterfunction fields intoproductionSlackClientWorker, replacing direct calls toslack.Newandslack.PostWebhookproductionSlackClientWorkercovering success and error paths for bothpostChannelMessageandpostWebhookMessageTest_PostToSlack_EdgeCasesusingNewTestClient(true, false)andNewTestClient(false, true)Test plan
go build ./...passes (compile-time guard verified)go test -race ./...passes with no failurespostChannelMessage(production): 0% → 100%postWebhookMessage(production): 0% → 100%