iam: onboarding client layer for IAM #90
Open
+1,994
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
============================================
+ Coverage 78.19% 82.39% +4.19%
+ Complexity 1730 43 -1687
============================================
Files 136 141 +5
Lines 7036 7162 +126
Branches 801 833 +32
============================================
+ Hits 5502 5901 +399
+ Misses 1112 832 -280
- Partials 422 429 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iam/iam-client/src/main/java/com/salesforce/multicloudj/iam/client/IamClient.java
Outdated
Show resolved
Hide resolved
iam/iam-client/src/main/java/com/salesforce/multicloudj/iam/model/TrustConfiguration.java
Outdated
Show resolved
Hide resolved
iam/iam-client/src/test/java/com/salesforce/multicloudj/iam/client/IamClientTest.java
Outdated
Show resolved
Hide resolved
iam/iam-client/src/test/java/com/salesforce/multicloudj/iam/client/IamClientTest.java
Outdated
Show resolved
Hide resolved
iam/iam-client/src/main/java/com/salesforce/multicloudj/iam/model/CreateOptions.java
Outdated
Show resolved
Hide resolved
iam/iam-client/src/main/java/com/salesforce/multicloudj/iam/model/CreateOptions.java
Outdated
Show resolved
Hide resolved
iam/iam-client/src/main/java/com/salesforce/multicloudj/iam/model/CreateOptions.java
Outdated
Show resolved
Hide resolved
iam/iam-client/src/main/java/com/salesforce/multicloudj/iam/model/Statement.java
Outdated
Show resolved
Hide resolved
iam/iam-client/src/main/java/com/salesforce/multicloudj/iam/model/PolicyDocument.java
Outdated
Show resolved
Hide resolved
iam/iam-client/src/main/java/com/salesforce/multicloudj/iam/model/PolicyDocument.java
Outdated
Show resolved
Hide resolved
iam/iam-client/src/main/java/com/salesforce/multicloudj/iam/model/PolicyDocument.java
Outdated
Show resolved
Hide resolved
iam/iam-client/src/main/java/com/salesforce/multicloudj/iam/model/CreateOptions.java
Show resolved
Hide resolved
sandeepvinayak
requested changes
Oct 27, 2025
iam/iam-client/src/main/java/com/salesforce/multicloudj/iam/model/CreateOptions.java
Outdated
Show resolved
Hide resolved
iam/iam-client/src/main/java/com/salesforce/multicloudj/iam/model/CreateOptions.java
Outdated
Show resolved
Hide resolved
iam/iam-client/src/main/java/com/salesforce/multicloudj/iam/model/PolicyDocument.java
Show resolved
Hide resolved
iam/iam-client/src/main/java/com/salesforce/multicloudj/iam/model/Statement.java
Show resolved
Hide resolved
DaisyModi
force-pushed
the
feature/add-iam-service
branch
from
a9c92ea to
6719880
Compare
DaisyModi
force-pushed
the
feature/add-iam-service
branch
from
2224a5e to
a6e6258
Compare
sandeepvinayak
changed the title
Comment on lines
+33
to
+60
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) { | ||
| return true; | ||
| } | ||
| if (o == null || getClass() != o.getClass()) { | ||
| return false; | ||
| } | ||
| CreateOptions that = (CreateOptions) o; | ||
| return Objects.equals(path, that.path) | ||
| && Objects.equals(maxSessionDuration, that.maxSessionDuration) | ||
| && Objects.equals(permissionBoundary, that.permissionBoundary); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(path, maxSessionDuration, permissionBoundary); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "CreateOptions{" | ||
| + "path='" + path + '\'' | ||
| + ", maxSessionDuration=" + maxSessionDuration | ||
| + ", permissionBoundary='" + permissionBoundary + '\'' | ||
| + '}'; | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
I see you have onboarded these methods for all classes? These should exist if they are required, I don't see the usage anywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
• Add IAM client module with cloud-agnostic API for identity and policy management
• Implement substrate-neutral PolicyDocument with fluent builder pattern
• Provide foundation for unified IAM operations across AWS, GCP, and AliCloud
Components
IamClient: Main entry point with builder pattern for identity lifecycle operations
PolicyDocument/Statement: Cloud-agnostic policy models with type-safe builders
Supporting models: TrustConfiguration and CreateOptions for flexible identity creation
Complete unit test coverage for all classes
Notes
Follows MultiCloudJ SPI pattern for future provider implementations
Client methods throw UnsupportedOperationException pending driver layer
Ready for AWS/GCP/AliCloud implementation modules