Skip to content

Conversation

@peter-esik
Copy link
Contributor

P4V restores the original filenames when syncing a file, but in the command line output of p4 commands the escapes are not restored, therefore the escape sequences "escaped" through p4-fusion into the Git repo filenames. This change resolves this bug.

P4V restores the original filenames when syncing a file, but in the command line output of p4 commands the escapes are not restored, therefore the escape sequences "escaped" through p4-fusion into the Git repo filenames. This change resolves this bug.

Co-authored-by: Márton Marczell <[email protected]>
@peter-esik
Copy link
Contributor Author

In this fix, FileData still "holds" relative paths in "depot path spec" format, so in theory, it can contain revision specifiers, etc. [Get|Set]RelativePath was renamed to reflect this. Unescape needs to be performed based on the concrete use case (as can be seen in main.cc).

This can be changed so FileData holds the unescaped version, if that's preferred.

@peter-esik
Copy link
Contributor Author

This will probably fix #74

@peter-esik
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant