Merged
Conversation
Updates `parseDate.ts` with improved comments and clarifications regarding the RFC6265 compliance. Adds tests for date parsing edge cases and boundaries: - Year boundaries (e.g., 1600, 9999, 10000) - Day-of-month limits (e.g., 0, 32) - Time component boundaries (e.g., 24:00:00, 23:60:00) - Month edge cases (e.g., single character months, invalid abbreviations) - Invalid date combinations as per RFC6265 - Handling of duplicate tokens and consecutive delimiters Closes #511
Also disabled `no-control-regex` rule since control characters are used throughout the spec.
wjhsf
approved these changes
Mar 6, 2026
colincasey
added a commit
that referenced
this pull request
Mar 13, 2026
Reorganize the flat it.each in domainMatch.spec.ts into grouped describe blocks for better readability and alignment with RFC 6265 Section 5.1.3 structure: - null and undefined inputs (library-specific behavior) - canonicalization (mixed case, leading dots, non-ASCII/punycode) - identical strings (RFC condition 1) - suffix matching with dot boundary (RFC condition 2) - IP address rejection (RFC condition 2's IP check) No test cases added or removed — purely structural reorganization. This follows the pattern established in PR #547 for date tests. Part of #513
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
parseDate.tswith improved comments and clarifications regarding the RFC6265 compliance.Adds tests for date parsing edge cases and boundaries:
Closes #511