W-16486531 feat: confirmation and warnings for convert behavior #1130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshackell-sfdc
approved these changes
Aug 13, 2024
Contributor
jshackell-sfdc
left a comment
jshackell-sfdc
left a comment
There was a problem hiding this comment.
Teeny edits. Thx.
Co-authored-by: Juliet Shackell <[email protected]>
shetzel
approved these changes
Aug 15, 2024
…hub.com/salesforcecli/plugin-deploy-retrieve into sm/convert-source-behavior-confirmation
shetzel
approved these changes
Aug 16, 2024
Contributor
|
QA Notes: I see the warnings, with dry-run and without. Looks great! |
iowillhoit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds a warning to make sure people don't have uncommited work before doing project modifications
adds a warning if people don't have main/default folders telling them that we're going to use them anyway
"reset" the sfProject Singleton instance to avoid stale presets during the conversion
QA notes:
yarn resolutions is there temporarily to force STL to also use that SDR prerel
you can use this command to go from "normal" to CL beta or CL beta2, or from one beta to the other.
What issues does this PR fix or reference?
@W-16486531@