Skip to content

W-17060314 fix: ms might be undefined #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shetzel merged 1 commit into from
Oct 24, 2024
Merged

W-17060314 fix: ms might be undefined #1195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions src/commands/project/retrieve/start.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,12 @@ export default class RetrieveMetadata extends SfCommand<RetrieveResultJson> {
);

protected retrieveResult!: RetrieveResult;
protected ms!: MultiStageOutput<{
status: string;
apiData: RetrieveVersionData;
}>;
protected ms:
| MultiStageOutput<{
status: string;
apiData: RetrieveVersionData;
}>
| undefined;

// eslint-disable-next-line complexity
public async run(): Promise<RetrieveResultJson> {
Expand Down Expand Up @@ -222,27 +224,27 @@ export default class RetrieveMetadata extends SfCommand<RetrieveResultJson> {

if (componentSetFromNonDeletes.size !== 0 || retrieveOpts.packageOptions?.length) {
Lifecycle.getInstance().on('apiVersionRetrieve', async (apiData: RetrieveVersionData) =>
Promise.resolve(this.ms.updateData({ apiData }))
Promise.resolve(this.ms?.updateData({ apiData }))
);
const retrieve = await componentSetFromNonDeletes.retrieve(retrieveOpts);
this.ms.goto('Waiting for the org to respond', { status: 'Pending' });

retrieve.onUpdate((data) => {
this.ms.goto('Waiting for the org to respond', { status: mdTransferMessages.getMessage(data.status) });
this.ms?.goto('Waiting for the org to respond', { status: mdTransferMessages.getMessage(data.status) });
});
retrieve.onFinish((data) => {
this.ms.goto('Done', { status: mdTransferMessages.getMessage(data.response.status) });
this.ms?.goto('Done', { status: mdTransferMessages.getMessage(data.response.status) });
});
retrieve.onCancel((data) => {
this.ms.updateData({ status: mdTransferMessages.getMessage(data?.status ?? 'Canceled') });
this.ms.error();
this.ms?.updateData({ status: mdTransferMessages.getMessage(data?.status ?? 'Canceled') });
this.ms?.error();
});
retrieve.onError((error: Error) => {
if (error.message.includes('client has timed out')) {
this.ms.updateData({ status: 'Client Timeout' });
this.ms?.updateData({ status: 'Client Timeout' });
}

this.ms.error();
this.ms?.error();
throw error;
});

Expand Down Expand Up @@ -300,8 +302,8 @@ export default class RetrieveMetadata extends SfCommand<RetrieveResultJson> {

protected catch(error: Error | SfError): Promise<never> {
if (!this.jsonEnabled() && error instanceof SourceConflictError && error.data) {
this.ms.updateData({ status: 'Failed' });
this.ms.error();
this.ms?.updateData({ status: 'Failed' });
this.ms?.error();
writeConflictTable(error.data);
// set the message and add plugin-specific actions
return super.catch({
Expand All @@ -310,7 +312,7 @@ export default class RetrieveMetadata extends SfCommand<RetrieveResultJson> {
actions: messages.getMessages('error.Conflicts.Actions'),
});
} else {
this.ms.error();
this.ms?.error();
}

return super.catch(error);
Expand Down
Loading