fix: handle single file components move to output-dir W-17615754#1289
Merged
fix: handle single file components move to output-dir W-17615754#1289
Conversation
Contributor
|
Code changes look good but I'd like to address 2 things found during QA/review:
|
shetzel
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
project retrieve start --output-dir lalawriting single-file components tolala/main/defaultinstead oflala.How does
--output-dirworks?<output-dir>/main/defaultproject retrieve startchecks if SDR retrieved files, if so then moves them from<output-dir>/main/defaultto<output-dirand nukesmain/default.The bug was in step 2, the command was skipping the file move if less than 2 files were retrieved (leaving single-file components like
GlobalValueSetin<output-dir>/main/default.Testing
sf org open -p lightning/setup/Picklists/homelala, see it being written tolala/main/default:sf project retrieve start -m GlobalValueSet --output-dir lalasf project retrieve start -m ApexClass:PagedResult --output-dir lalaThe component/file response check was introduced here to fix a ENOENT err:
#1236
the change in this PR updates the check to skip the file move if all retrieves failed so it shouldn't cause a regression and also fixes the

ENOENTerror on +1 failures:What issues does this PR fix or reference?
@W-17615754@
forcedotcom/cli#3177