Skip to content

fix: optionally subscribe to SDR events, rather than optionally creat @W-18979695@ #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdonnalley merged 2 commits into from
Jul 7, 2025
Merged

fix: optionally subscribe to SDR events, rather than optionally creat @W-18979695@ #1395

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2f5ac9
fix: optionally subscribe to SDR events, rather than optionally creat…
WillieRuemmele Jul 7, 2025
759dc40
chore: undo temp var
WillieRuemmele Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions src/utils/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,17 +143,14 @@ export async function executeDeploy(
} else {
// instantiate source tracking
// stl will decide, based on the org's properties, what needs to be done
let stl: SourceTracking | undefined;
if (!opts['dry-run'] || !(await org.tracksSource())) {
stl = await SourceTracking.create({
org,
// mdapi format deploys don't require a project, but at this point we need one
project: project ?? (await SfProject.resolve()),
subscribeSDREvents: true,
ignoreConflicts: opts['ignore-conflicts'],
});
registry = stl.registry;
}
const stl = await SourceTracking.create({
org,
// mdapi format deploys don't require a project, but at this point we need one
project: project ?? (await SfProject.resolve()),
subscribeSDREvents: !opts['dry-run'] || !(await org.tracksSource()),
ignoreConflicts: opts['ignore-conflicts'],
});
registry = stl.registry;

componentSet = await buildComponentSet(opts, stl);
if (componentSet.size === 0) {
Expand Down