fix: refactored code

Author: pulkit0555

src/shared/experience/expSite.ts

@@ -37,6 +37,8 @@ export class ExperienceSite {
     this.org = org;
     this.siteDisplayName = siteName.trim();
     this.siteName = this.siteDisplayName.replace(' ', '_');
+    // Replace any special characters in site name with underscore
+    this.siteName = this.siteName.replace(/[^a-zA-Z0-9]/g, '_');
   }
 
   /**
@@ -179,13 +181,6 @@ export class ExperienceSite {
 
   public async getRemoteMetadata(): Promise<SiteMetadata | undefined> {
     if (this.metadataCache.remoteMetadata) return this.metadataCache.remoteMetadata;
-    // Check if there are special characters in the site name
-    const isInvalidSiteName = hasSpacesOrSpecialChars(this.siteName);
-    // const originalSiteName = this.siteName;
-    if (isInvalidSiteName) {
-      const updatedSiteName = replaceSpacesAndSpecialChars(this.siteName);
-      this.siteName = updatedSiteName;
-    }
     const result = await this.org
       .getConnection()
       .query<{ Name: string; LastModifiedDate: string }>(
@@ -363,27 +358,3 @@ function getSiteNameFromStaticResource(staticResourceName: string): string {
   }
   return parts.slice(4).join(' ');
 }
-
-export function replaceSpacesAndSpecialChars(value: string): string {
-  // Replace any special characters with underscore
-  value = value.replace(/[^a-zA-Z0-9]/g, '_');
-
-  // Replace spaces with underscore
-  value = value.replace(/ /g, '_');
-
-  return value;
-}
-
-export function hasSpacesOrSpecialChars(value: string): boolean {
-  // Check for spaces
-  if (value.includes(' ')) {
-    return true;
-  }
-
-  // Check for special characters
-  if (/[^\w]/.test(value)) {
-    return true;
-  }
-
-  return false;
-}

test/spec/expSite.spec.ts

@@ -7,40 +7,7 @@
 import { expect } from 'chai';
 import { Connection, Org } from '@salesforce/core';
 import sinon from 'sinon';
-import {
-  replaceSpacesAndSpecialChars,
-  hasSpacesOrSpecialChars,
-  ExperienceSite,
-} from '../../src/shared/experience/expSite.js';
-
-describe('replaceSpacesAndSpecialChars', () => {
-  it('should replace spaces and special characters with underscores', () => {
-    const input = 'site#name@with-special%chars with spaces';
-    const expectedOutput = 'site_name_with_special_chars_with_spaces';
-    const output = replaceSpacesAndSpecialChars(input);
-    expect(output).to.equal(expectedOutput);
-  });
-});
-
-describe('hasSpacesOrSpecialChars', () => {
-  it('should return true if the input string has spaces', () => {
-    const input = 'Hello World';
-    const output = hasSpacesOrSpecialChars(input);
-    expect(output).to.be.true;
-  });
-
-  it('should return true if the input string has special characters', () => {
-    const input = 'Hello, @#';
-    const output = hasSpacesOrSpecialChars(input);
-    expect(output).to.be.true;
-  });
-
-  it('should return false if the input string has neither spaces nor special characters', () => {
-    const input = 'HelloWorld';
-    const output = hasSpacesOrSpecialChars(input);
-    expect(output).to.be.false;
-  });
-});
+import { ExperienceSite } from '../../src/shared/experience/expSite.js';
 
 describe('getRemoteMetadata', () => {
   it('should return remote metadata when it exists', async () => {