feat: @W-18289065@ org-based component preview#447
Conversation
| ); | ||
|
|
||
| // Open the browser and navigate to the right page | ||
| await this.config.runCommand('org:open', launchArguments); |
There was a problem hiding this comment.
@bpbuch I need to be able to get the proper URL and iframe it inside of the VSCode webview. Right now it works because I know the URL is localhost, but with this change how will I be able to get the right URL and set that into the iframe?
There was a problem hiding this comment.
Also we still want a way to not automatically launch the browser when running the command in VSCode / Code Builder (i.e. we only want to open the preview panel)
There was a problem hiding this comment.
how will I be able to get the right URL and set that into the iframe?
We will need to follow up this PR with a programatic way to start the local dev server and access the target org URL(containing the local dev server URL and token). Alternatively, the VS Code extension could directly configure, launch, and manage the local dev server without a dependency on the CLI.
we still want a way to not automatically launch the browser
For the CLI use case, I think launching the browser is almost required because the local dev server port and user token are resolved when the command is invoked. For VS Code, the programmatic access should solve this problem as well.
There was a problem hiding this comment.
I've added a followup work item for @Shinoni to take a look at
bpbuch
force-pushed
the
component-preview
branch
from
1f731b3 to
f3fc413
Compare
2 participants
What does this PR do?
Moving component preview to an org-based solution using the LWR preview application, and removes the local-only component development flow.
With this transition, the usage of
@lwrjsfor the local dev server is replaced with thelwc-dev-server.What issues does this PR fix or reference?
@W-18289065@