fix: adressed comments for omnistudio settings metadata

Author: shaurabh-tiwari-git

messages/assess.json

@@ -197,6 +197,6 @@
   "dmNameUpdateFailed": "DM reference %s can’t be updated",
   "invalidTypeAssessErrorMessage": "We couldn't assess your Omnistudio components in the %s namespace. Select the correct namespace and try again",
   "assessmentSuccessfulMessage": "Migration assessment for org %s is complete and reports are ready for review in the folder %s",
-  "errorCheckingOmniStudioMetadata": "We couldn't check whether the Omnistudio Metadata is enabled: %s. Try again later.",
+  "errorCheckingOmniStudioMetadata": "Error while checking the Omnistudio settings metadata status: %s.",
   "omniStudioSettingsMetadataAlreadyEnabled": "The Omnistudio Metadata setting is already enabled with standard data model. No need for migration."
 }

messages/migrate.json

@@ -255,10 +255,11 @@
   "metadataCleanupConsentMessage": "By proceeding further, you hereby consent to clean up the Omnistudio metadata tables. Proceeding with the cleanup process will permanently delete all records from OmniUiCardConfig, OmniScriptConfig, OmniIntegrationProcConfig, and OmniDataTransformConfig tables. Do you want to proceed? [y/n]",
   "metadataCleanupConsentNotGiven": "You’ve not consented to proceed with the Omnistudio metadata table cleanup. We’ll not be able to proceed with the migration.",
   "omniStudioMetadataEnableConsentMessage": "As part of the migration process, the Omnistudio Metadata setting will be enabled. After the setting is enabled, you cannot disable it. Do you want to proceed? [y/n]",
-  "errorCheckingOmniStudioMetadata": "We couldn't check whether the Omnistudio Metadata is enabled: %s. Try again later.",
+  "errorCheckingOmniStudioMetadata": "Error while checking the Omnistudio settings metadata status: %s.",
   "omniStudioSettingsMetadataAlreadyEnabled": "The Omnistudio Metadata setting is already enabled with standard data model. No need for migration.",
   "omniStudioSettingsMetadataEnabled": "The Omnistudio Metadata setting is enabled with standard data model.",
-  "errorEnablingOmniStudioSettingsMetadata": "We couldn't enable the Omnistudio Metadata setting: %s. Enable it manually.",
+  "timeoutEnablingOmniStudioSettingsMetadata": "Timeout while checking the metadata enablement status. Tried for %s seconds.",
+  "errorEnablingOmniStudioSettingsMetadata": "Error while enabling the Omnistudio Metadata setting: %s. Enable it manually.",
   "manuallyEnableOmniStudioSettingsMetadata": "Manually enable the Omnistudio Metadata setting in your org’s Omnistudio Settings page.",
   "omniStudioMetadataEnableConsentNotGiven": "You’ve not consented to proceed with enabling the Omnistudio Metadata setting. We’ll not be able to proceed with the migration.",
   "enablingOmniStudioSettingsMetadataStatus": "Enabling Omnistudio Metadata setting…",

src/migration/postMigrate.ts

@@ -144,9 +144,9 @@ export class PostMigrate extends BaseMigrationTool {
         */
         const maxAttempts = 6;
         let attempts = 0;
+        const metadataService = new OmniStudioMetadataCleanupService(this.connection, this.messages);
         while (attempts < maxAttempts) {
           await new Promise((resolve) => setTimeout(resolve, 20000));
-          const metadataService = new OmniStudioMetadataCleanupService(this.connection, this.messages);
           const isConfigTablesEmpty = await metadataService.hasCleanOmniStudioMetadataTables(); //Check is the config tables are populated or not.
           if (!isConfigTablesEmpty) {
             // If the config tables are populated, means the metadata is enabled.
@@ -157,7 +157,7 @@ export class PostMigrate extends BaseMigrationTool {
         }
         if (attempts === maxAttempts) {
           // TODO: We need to figure out and show the user that what is the actual issue which is causing the metadata to not be enabled.
-          Logger.error(this.messages.getMessage('errorEnablingOmniStudioSettingsMetadata', ['Unknown error']));
+          Logger.error(this.messages.getMessage('timeoutEnablingOmniStudioSettingsMetadata', [maxAttempts * 20]));
           userActionMessage.push(this.messages.getMessage('manuallyEnableOmniStudioSettingsMetadata'));
         }
       } else {