chore: address review concerns

Author: peternhale

src/commands/org/create/sandbox.ts

@@ -141,12 +141,9 @@ export default class CreateSandbox extends SandboxCommandBase<SandboxProcessObje
       ...(this.flags.clone ? { SourceSandboxName: this.flags.clone } : {}),
       ...(!this.flags.clone && this.flags['license-type'] ? { LicenseType: this.flags['license-type'] } : {}),
     };
-    const { sandboxReq } = await createSandboxRequest(
-      !!this.flags.clone,
-      this.flags['definition-file'],
-      undefined,
-      requestOptions
-    );
+    const { sandboxReq } = !this.flags.clone
+      ? await createSandboxRequest(false, this.flags['definition-file'], undefined, requestOptions)
+      : await createSandboxRequest(true, this.flags['definition-file'], undefined, requestOptions);
     return {
       ...sandboxReq,
       ...(this.flags.clone ? { SourceId: await this.getSourceId() } : {}),

src/shared/sandboxRequest.ts

@@ -20,6 +20,18 @@ export const generateSboxName = async (): Promise<string> => {
   return generated;
 };
 
+export async function createSandboxRequest(
+  isClone: true,
+  definitionFile: string | undefined,
+  logger?: Logger | undefined,
+  properties?: Record<string, string | undefined>
+): Promise<{ sandboxReq: SandboxRequest; srcSandboxName: string }>;
+export async function createSandboxRequest(
+  isClone: false,
+  definitionFile: string | undefined,
+  logger?: Logger | undefined,
+  properties?: Record<string, string | undefined>
+): Promise<{ sandboxReq: SandboxRequest }>;
 export async function createSandboxRequest(
   isClone = false,
   definitionFile: string | undefined,