Skip to content

Added Key support for Authorization header.#34

Merged
sonnykt merged 1 commit into1.xfrom
feature/key_auth
Dec 28, 2024
Merged

Added Key support for Authorization header.#34
sonnykt merged 1 commit into1.xfrom
feature/key_auth

Conversation

@sonnykt
Copy link
Member

@sonnykt sonnykt commented Dec 27, 2024

Checklist before requesting a review

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

  1. Added Key support for Authorization header.

Screenshots

image

@sonnykt sonnykt added the Needs review Dev complete ready for review label Dec 27, 2024
@sonnykt sonnykt self-assigned this Dec 27, 2024
@codecov
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 3.52%. Comparing base (a161afc) to head (7353a02).
Report is 2 commits behind head on 1.x.

Files with missing lines Patch % Lines
src/WebformThirdPartySettingsFormAlter.php 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               1.x     #34      +/-   ##
==========================================
- Coverage     3.56%   3.52%   -0.05%     
  Complexity     250     250              
==========================================
  Files           16      16              
  Lines         1093    1106      +13     
==========================================
  Hits            39      39              
- Misses        1054    1067      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonnykt sonnykt merged commit 84852f3 into 1.x Dec 28, 2024
12 of 14 checks passed
@sonnykt sonnykt deleted the feature/key_auth branch December 28, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs review Dev complete ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant