Merged
Conversation
2e26f48 to
29a971d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.x #36 +/- ##
==============================================
+ Coverage 26.91% 100.00% +73.08%
- Complexity 275 279 +4
==============================================
Files 16 16
Lines 1107 1124 +17
==============================================
+ Hits 298 1124 +826
+ Misses 809 0 -809 ☔ View full report in Codecov by Sentry. |
44bc77d to
b2c1be0
Compare
ff49047 to
e7a37e6
Compare
e7a37e6 to
f8804fa
Compare
f8804fa to
3ff9b3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
[#123] Verb in past tense with dot at the end.Changedsection about WHY something was done if this was not a normal implementationChanged
Screenshots