Skip to content

Added kernel tests and cleaned up configs.#36

Merged
sonnykt merged 2 commits into1.xfrom
feature/kernel_tests
Jan 5, 2025
Merged

Added kernel tests and cleaned up configs.#36
sonnykt merged 2 commits into1.xfrom
feature/kernel_tests

Conversation

@sonnykt
Copy link
Member

@sonnykt sonnykt commented Dec 30, 2024

Checklist before requesting a review

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

@codecov
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (04e29c4) to head (3ff9b3a).
Report is 1 commits behind head on 1.x.

Additional details and impacted files
@@              Coverage Diff               @@
##                1.x       #36       +/-   ##
==============================================
+ Coverage     26.91%   100.00%   +73.08%     
- Complexity      275       279        +4     
==============================================
  Files            16        16               
  Lines          1107      1124       +17     
==============================================
+ Hits            298      1124      +826     
+ Misses          809         0      -809     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonnykt sonnykt force-pushed the feature/kernel_tests branch 12 times, most recently from 44bc77d to b2c1be0 Compare January 3, 2025 01:43
@sonnykt sonnykt force-pushed the feature/kernel_tests branch 6 times, most recently from ff49047 to e7a37e6 Compare January 5, 2025 13:10
@sonnykt sonnykt marked this pull request as ready for review January 5, 2025 13:15
@sonnykt sonnykt added the Needs review Dev complete ready for review label Jan 5, 2025
@sonnykt sonnykt force-pushed the feature/kernel_tests branch from e7a37e6 to f8804fa Compare January 5, 2025 13:20
@sonnykt sonnykt force-pushed the feature/kernel_tests branch from f8804fa to 3ff9b3a Compare January 5, 2025 13:21
@sonnykt sonnykt changed the title Added kernel tests. Added kernel tests and cleaned up configs. Jan 5, 2025
@sonnykt sonnykt merged commit f49d4c5 into 1.x Jan 5, 2025
14 checks passed
@sonnykt sonnykt deleted the feature/kernel_tests branch January 5, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs review Dev complete ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant