Skip to content

[GOVRACPROD-46] Add warning message and popup for checkbox 'Enable OpenFisca RaC integration' in webform.#50

Merged
gargsuchi merged 2 commits into1.xfrom
feature/GOVRACPROD-46
Dec 9, 2025
Merged

[GOVRACPROD-46] Add warning message and popup for checkbox 'Enable OpenFisca RaC integration' in webform.#50
gargsuchi merged 2 commits into1.xfrom
feature/GOVRACPROD-46

Conversation

@g2410g
Copy link
Collaborator

@g2410g g2410g commented Dec 3, 2025

https://salsadigital.atlassian.net/browse/GOVRACPROD-46

Checklist before requesting a review

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

  1. Add warning message and popup for checkbox 'Enable OpenFisca RaC integration' in webform.

Screenshots

Screenshot 2025-12-03 at 8 36 59 AM Screenshot 2025-12-03 at 8 37 04 AM

@g2410g g2410g self-assigned this Dec 3, 2025
@g2410g g2410g requested a review from gargsuchi December 3, 2025 03:07
@g2410g g2410g added the Needs review Dev complete ready for review label Dec 3, 2025
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.91%. Comparing base (841389b) to head (d52cc1d).
⚠️ Report is 1 commits behind head on 1.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                1.x      #50   +/-   ##
=========================================
  Coverage     99.91%   99.91%           
- Complexity      287      288    +1     
=========================================
  Files            16       16           
  Lines          1127     1128    +1     
=========================================
+ Hits           1126     1127    +1     
  Misses            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gargsuchi gargsuchi merged commit 035cad9 into 1.x Dec 9, 2025
12 of 14 checks passed
@gargsuchi gargsuchi deleted the feature/GOVRACPROD-46 branch December 9, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs review Dev complete ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants