Update avro_turf to 1.20.1+, remove sinatra dependency#12
Draft
Update avro_turf to 1.20.1+, remove sinatra dependency#12
Conversation
Changes: - Update avro_turf dependency from >= 0.8.0 to >= 1.20.1 - Remove sinatra development dependency - Bump version to 0.6.0 - Update CHANGELOG avro_turf 1.20.1+ uses a custom Rack-based implementation for FakeConfluentSchemaRegistryServer instead of Sinatra, eliminating the need for this transitive dependency. Since AvroSchemaRegistry::FakeServer extends FakeConfluentSchemaRegistryServer from avro_turf, it will automatically benefit from the Sinatra-free implementation once avro_turf is updated. Ref: dasch/avro_turf#237 Ref: salsify/con-u#7005
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
avro_turfdependency to version 1.20.1+ and removes thesinatradevelopment dependency, which is no longer needed.Changes
avro_turfruntime dependency from>= 0.8.0to>= 1.20.1sinatradevelopment dependency0.6.0Background
As of
avro_turfversion 1.20.1 (PR #237), theFakeConfluentSchemaRegistryServeruses a custom Rack-based implementation instead of Sinatra. This eliminates the need for Sinatra as a transitive dependency.Since
AvroSchemaRegistry::FakeServerextendsFakeConfluentSchemaRegistryServerfromavro_turf, it will automatically benefit from this Sinatra-free implementation once we update the dependency.Related