Don't clear caches if we're setting current to the existing value#28
Open
Don't clear caches if we're setting current to the existing value#28
Conversation
…void invalidating caches
atsheehan
approved these changes
Apr 8, 2021
Contributor
atsheehan
left a comment
atsheehan
left a comment
There was a problem hiding this comment.
Found this one while clearing out my PR inbox, woops :)
LGTM after bumping the version to the latest value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
current=andcurrent_id=to be no-ops if setting current to the existing value which avoids clearing any caches. It also fixesclear_current!to ensure they propagate to dependent objects.@atsheehan - you're prime