Skip to content

fix(apache.service.running): prevent recursive requisite #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dehnert wants to merge 3 commits into
base: master
Choose a base branch
from

fix(apache.service.running): further improve circular requisites

3d8b560
Select commit
Loading
Failed to load commit list.
Open

fix(apache.service.running): prevent recursive requisite #391

fix(apache.service.running): further improve circular requisites
3d8b560
Select commit
Loading
Failed to load commit list.
coqbot-app / GitLab CI job commitlint (pull request) failed Jul 13, 2025 in 0s

Test has failed on GitLab CI

This job has failed. If you need to, you can restart it directly in the GitHub interface using the "Re-run" button.

We show below the last 40 lines of the trace from GitLab (the complete trace is available here).

Details

 * [new branch]      pr-389         -> upstream/pr-389
 * [new branch]      pr-391         -> upstream/pr-391
 * [new branch]      pre-commit-ci-update-config -> upstream/pre-commit-ci-update-config
$ export COMMITLINT_FROM="$(git merge-base upstream/master HEAD)"
$ export COMMITLINT_TO="${CI_COMMIT_SHA}"
$ if [ "${GITLAB_USER_LOGIN}" = "coqbot" ] \ # collapsed multi-line command
[detached HEAD 9aefa49] chore: reword coqbot merge commit message for commitlint
 Author: coqbot <coqbot@users.noreply.github.com>
 Date: Sun Jul 13 04:44:01 2025 +0000
$ commitlint --from "${COMMITLINT_FROM}" --to   "${COMMITLINT_TO}" --verbose
⧗   input: chore: reword coqbot merge commit message for commitlint
✔   found 0 problems, 0 warnings
⧗   input: fix(apache.service.running): further improve circular requisites
✔   found 0 problems, 0 warnings
⧗   input: fix(apache.service.running): More consistent amount of logging

If Apache fails to start, on a non-systemd system, we dump 20 lines of logs,
which seems like enough to give a good hint of what went wrong.

When available, however, we instead use `journalctl -xe`. `journalctl -x`
annotates each log message, resulting in a large amount of context for each
line. `journalctl -e` implicitly allows a cap of 1000 lines of *log* to be
printed, which is further multiplied by the annotations. IME the annotations
aren't actually useful for Apache restarts (*Apache's* output doesn't have any,
so it's just a lot of explanation of what systemd is doing).

Rather than cluttering up Salt's output, this change makes `journalctl`
consistent with non-systemd log dumping: 20 lines max, with no context. An
admin can easily run `journalctl -xe` themselves if they actually need the
annotations or more lines.
✖   subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]

✖   found 1 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

⧗   input: fix(apache.service.running): prevent recursive requisite
✔   found 0 problems, 0 warnings
Cleaning up project directory and file based variables
ERROR: Job failed: exit code 1
View more details on coqbot-app