named-checkconf, named-checkzone and rndc reload for dynamic zones #125
Open
morgana2313 wants to merge 6 commits intosaltstack-formulas:masterfrom
Open
named-checkconf, named-checkzone and rndc reload for dynamic zones #125morgana2313 wants to merge 6 commits intosaltstack-formulas:masterfrom
morgana2313 wants to merge 6 commits intosaltstack-formulas:masterfrom
Conversation
aboe76
requested review from
aanriot,
alxwr and
ryanwalder
and removed request for
alxwr and
ryanwalder
Contributor
|
@morgana2313 please take a look at the travis failures |
aanriot
approved these changes
Jan 21, 2019
aanriot
suggested changes
Jan 21, 2019
Contributor
aanriot
left a comment
aanriot
left a comment
There was a problem hiding this comment.
I'm not able to test the behaviour of these changes at the moment but the diff looks ok. But a endif tag has to be added to fix Travis tests.
| {%- set zone_source = 'salt://bind/files/zone.jinja' if zone_records != {} else 'salt://' ~ map.zones_source_dir ~ '/' ~ file %} | ||
| {%- set serial_auto = salt['pillar.get']('bind:available_zones:' + zone + ':soa:serial', '') == 'auto' %} | ||
|
|
||
| {% if file and zone_data['type'] == 'master' -%} |
Contributor
There was a problem hiding this comment.
Starting from here, a endif tag appears to be missing.
Fix missing endif tag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull fixes #122 and #124.