Skip to content

Conversation

@alxwr
Copy link
Member

@alxwr alxwr commented Jul 4, 2023

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

host:
----------
          ID: icinga2-web2-required-packages
    Function: pkg.installed
      Result: False
     Comment: An exception occurred in this state: Traceback (most recent call last):
                File "/usr/local/lib/python3.8/site-packages/salt/state.py", line 2385, in call
                  ret = self.states[cdata["full"]](
                File "/usr/local/lib/python3.8/site-packages/salt/loader/lazy.py", line 149, in __call__
                  return self.loader.run(run_func, *args, **kwargs)
                File "/usr/local/lib/python3.8/site-packages/salt/loader/lazy.py", line 1232, in run
                  return self._last_context.run(self._run_as, _func_or_method, *args, **kwargs)
                File "/usr/local/lib/python3.8/site-packages/salt/loader/lazy.py", line 1247, in _run_as
                  return _func_or_method(*args, **kwargs)
                File "/usr/local/lib/python3.8/site-packages/salt/loader/lazy.py", line 1280, in wrapper
                  return f(*args, **kwargs)
                File "/usr/local/lib/python3.8/site-packages/salt/states/pkg.py", line 1703, in installed
                  result = _find_install_targets(
                File "/usr/local/lib/python3.8/site-packages/salt/states/pkg.py", line 584, in _find_install_targets
                  desired = _repack_pkgs(pkgs, normalize=normalize)
                File "/usr/local/lib/python3.8/site-packages/salt/modules/pkg_resource.py", line 38, in _repack_pkgs
                  raise SaltInvocationError(
              salt.exceptions.SaltInvocationError: You are passing a list of packages that contains duplicated packages names: ['mod_php82', 'php82', 'php82-gd', 'php82-intl', 'php82-pgsql', 'php82-gd']. This cannot be processed. In case you are targeting different versions of the same package, please target them individually
     Started: 01:22:49.586428
    Duration: 52.488 ms
     Changes:   

Summary for host
--------------
Succeeded: 212
Failed:      1
--------------
Total states run:     213
Total run time:    14.650 s

Describe the changes you're proposing

Removed the duplicate. => Everything works again. :-)

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

----------                                                           
          ID: icinga2-web2-required-packages
    Function: pkg.installed                                          
      Result: True           
     Comment: All specified packages are already installed                                                                                 
     Started: 01:34:16.280538                                                                                                              
    Duration: 47.853 ms                                              
     Changes:                                                                                                                              
----------

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@alxwr alxwr requested a review from myii July 4, 2023 23:36
@alxwr alxwr self-assigned this Jul 4, 2023
@alxwr alxwr force-pushed the fix-osfamilymap branch from 5238d4d to 3fad9ae Compare July 4, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant