Skip to content

Conversation

@alxwr
Copy link
Member

@alxwr alxwr commented Nov 25, 2022

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Makes the shell of user jenkins configurable.

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

None.

Describe the changes you're proposing

Use the map.jinja mechanism to make jenkins' shell configurable.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

----------
          ID: jenkins_user
    Function: user.present
        Name: jenkins
      Result: True
     Comment: Updated user jenkins
     Started: 13:13:13.593646
    Duration: 202.744 ms
     Changes:   
              ----------
              shell:
                  /usr/local/bin/bash
----------

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@alxwr alxwr self-assigned this Nov 25, 2022
@alxwr alxwr requested a review from myii November 25, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant