Open
Conversation
|
If you absolutely must break backwards compatibility, A. you should justify the need B. you should document it in the README or similar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request aims to let the user choose the Logstash configuration layout. Indeed, one might want to stack Logstash configuration files as traits (e.g.
10-syslog.conf,10-custom-input.conf,20-custom-filter.conf) as the Pillar +top.slsstructure allows it. The current layout (i.e.01-inputs.conf,02-filters.conf,03-outputs.conf) is too much static and sticks the user to defining a Logstash configuration per host.Note that this change breaks backward compatibility.
Still to be done: updating the README section "Pillar Data Explained"