Skip to content

feat(config): support emptying config#568

Open
tacerus wants to merge 1 commit intosaltstack-formulas:masterfrom
tacerus:feat/suse/default-config
Open

feat(config): support emptying config#568
tacerus wants to merge 1 commit intosaltstack-formulas:masterfrom
tacerus:feat/suse/default-config

Conversation

@tacerus
Copy link
Contributor

@tacerus tacerus commented Apr 6, 2025

The removal option is not suitable for systems where Salt is installed from distribution packages which place back a default configuration. Allow emptying the file instead of removing it, to benefit from removing any undesired, unmanaged, configuration changes in it, whilst not causing ping-pong between Salt and package updates.

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Reference pillar.example.

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@tacerus tacerus requested a review from a team as a code owner April 6, 2025 14:30
@tacerus tacerus force-pushed the feat/suse/default-config branch 5 times, most recently from fbc64f6 to 9e120d2 Compare October 13, 2025 14:17
The removal option is not suitable for systems where Salt is installed
from distribution packages which place back a default configuration.
Allow emptying the file instead of removing it, to benefit from removing
any undesired, unmanaged, configuration changes in it, whilst not
causing ping-pong between Salt and package updates.

Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
@tacerus tacerus force-pushed the feat/suse/default-config branch from 9e120d2 to 14944d9 Compare October 13, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants