create macros from pillars #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi, By now it's more then a year that I'm using it on debian environment without any issue. @puneetk cloud you have a look at it? Thanks in advance! |
Sjd-Risca
force-pushed
the
macroFromPillars
branch
from
3a375fc to
c43b59f
Compare
Sjd-Risca
force-pushed
the
macroFromPillars
branch
from
c43b59f to
29cc2fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the functionality to create macro files from pillars and not just by copying them from the path /shorewall/files/macro.MyMacro of the formula.
I believe that this way it will be easier to use the shorewall formula to create custom macros: it's no more required to fork the formula just for adding some custom macros.
Hoping that you'll enjoy,
best regards.