ci: merge travis matrix, add salt-lint & rubocop to lint job
#49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```bash
Examining vault/files/cert-gen.sh.j2 of type state
[204] Lines should be no longer that 160 chars
vault/files/cert-gen.sh.j2:34
root_subj="/C={{ vault.self_signed_cert.country }}/ST={{ vault.self_signed_cert.state }}/L={{ vault.self_signed_cert.city }}/O={{ vault.self_signed_cert.org }}/OU={{ vault.self_signed_cert.org_unit }}/CN=$root\_ca"
[204] Lines should be no longer that 160 chars
vault/files/cert-gen.sh.j2:75
child_subj="/C={{ vault.self_signed_cert.country }}/ST={{ vault.self_signed_cert.state }}/L={{ vault.self_signed_cert.city }}/O={{ vault.self_signed_cert.org }}/OU={{ vault.self_signed_cert.org_unit }}/CN=$child_name"
```
dafyddj
approved these changes
Oct 9, 2019
Contributor
dafyddj
left a comment
dafyddj
left a comment
There was a problem hiding this comment.
Many great improvements - and thanks for taking my comments on board 👍.
Contributor
Author
|
You're welcome, they were good suggestions! Thanks for the merge. |
|
🎉 This PR is included in version 1.2.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
salt-lint&rubocoptolintjob myii/ssf-formula#60@dafyddj I've rolled this out as one of the first conversions, so that we minimise delays for #48. Note that this involved fixing one file to get
salt-lintpassing:Otherwise, as I mentioned in saltstack-formulas/template-formula#175 (comment), we're using
allow_failureson the separaterubocoplint job.