Conversation
dwoz
left a comment
There was a problem hiding this comment.
Pre-commit needs to be fixed in order for this to get merged.
|
@mtelka FYI - no issue associated with this PR, which would help in identifying the problem being fixed. Given Salt Core dropped support for native minions Solaris 10 and 11 in 3005, wondering about this PR. Presume pip installing Salt on Solaris or Illumos, or equivalent. Also. note minimum Python version 3.10 is supported by 3006.x and above (work on going to get Py 3.12 support but unfinished). The docs stating that haven't been released yet due to staff leaving (months late on that) |
|
This fixes #7. We do have salt packaged for OpenIndiana. However I'm not sure how it works. |
|
Would you mind fixing the pre-commit failures please? |
Who? Me? I'm very sorry, but I've no idea how to fix that. I do see two failures there: Failure 1: This is something apparently not related to this change because it lists files that are not touched by this PR. Failure 2: Again, I do not understand how is this related to my change. So in short, it looks like both issues were there even before my PR. |
|
@mtelka Pre-commit failures are probably due to aging of the various pre-commit tests. Classic case of Software Rot over time. However Pottery Barn rules apply, touch and break it, you own it :D . Take it as an opportunity to learn. |
Test results with this change:
Fixes #7.