This repository was archived by the owner on Jan 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 41
SEP 35: sep for standardizing log rotate settings in minion configs #57
Open
Bacon-Unlimited
wants to merge
2
commits into
saltstack:master
Choose a base branch
from
Bacon-Unlimited:log-rotate-minion-configs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
- Feature Name: Cross Platform Log Rotate in Minion Config | ||
- Start Date: 2021-08-12 | ||
- SEP Status: Draft | ||
- SEP PR: (leave this empty) | ||
- Salt Issue: (leave this empty) | ||
|
||
# Summary | ||
[summary]: #summary | ||
|
||
Purpose is to make current salt-minion log configs (for performing log rotation) available on all operating systems. Currently, Windows has two minion configs that set the maz size of the log and set the max number of log files. However, these configs do not apply to other platforms. | ||
The work would be to streamline the log rotation by using the most _salty_ features (ie. minion-configs), instead of relying on platform based solutions which may, or may not, be controlled by a different execution/state module, which may, or may not, be updated regularly. | ||
Bacon-Unlimited marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
||
# Design | ||
[design]: #detailed-design | ||
|
||
Salt-minion for all platforms to use these two minion-configs settings: | ||
- log_rotate_max_bytes: | ||
- log_rotate_backup_count: | ||
|
||
## Alternatives | ||
[alternatives]: #alternatives | ||
|
||
An alternative would need to free up the minion log (file acls/permissions) file so that the log can be manipulated by external processes *while* salt-minion svc is running. | ||
|
||
Note: I do not like, nor recommend this alternative, as it seems to contraindicate current practices of cross-platform solution with minion configs. | ||
|
||
## Unresolved questions | ||
[unresolved]: #unresolved-questions | ||
|
||
Unknown how to set *nix and MacOS platforms to perform log rotation as a function of minion configs | ||
|
||
# Drawbacks | ||
[drawbacks]: #drawbacks | ||
|
||
- Time to dev | ||
- Maybe no one else really cares |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.